Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/resources/options/clear_browser_data_overlay.html

Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data". (Closed)
Patch Set: Add comments for issues with incomplete data deletion Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <div id="clear-browser-data-overlay" class="page not-resizable" hidden> 1 <div id="clear-browser-data-overlay" class="page not-resizable" hidden>
2 <div class="close-button"></div> 2 <div class="close-button"></div>
3 <h1 i18n-content="clearBrowserDataOverlay"></h1> 3 <h1 i18n-content="clearBrowserDataOverlay"></h1>
4 <!-- NOTE: Make sure there's not whitespace between <div></div> for 4 <!-- NOTE: Make sure there's not whitespace between <div></div> for
5 #clear-browser-data-info-banner as it's styled with :empty. --> 5 #clear-browser-data-info-banner as it's styled with :empty. -->
6 <div id="clear-browser-data-info-banner"></div> 6 <div id="clear-browser-data-info-banner"></div>
7 <div id="cbd-content-area" class="content-area"> 7 <div id="cbd-content-area" class="content-area">
8 <span i18n-content="clearBrowserDataLabel"></span> 8 <span i18n-content="clearBrowserDataLabel"></span>
9 <select id="clear-browser-data-time-period" 9 <select id="clear-browser-data-time-period"
10 i18n-options="clearBrowserDataTimeList" 10 i18n-options="clearBrowserDataTimeList"
(...skipping 22 matching lines...) Expand all
33 pref="browser.clear_data.download_history" type="checkbox"> 33 pref="browser.clear_data.download_history" type="checkbox">
34 <span i18n-content="deleteDownloadHistoryCheckbox"></span> 34 <span i18n-content="deleteDownloadHistoryCheckbox"></span>
35 <span class="controlled-setting-indicator" 35 <span class="controlled-setting-indicator"
36 pref="history.deleting_enabled"> 36 pref="history.deleting_enabled">
37 </span> 37 </span>
38 </label> 38 </label>
39 </div> 39 </div>
40 <div id="delete-cookies-container" class="checkbox"> 40 <div id="delete-cookies-container" class="checkbox">
41 <label> 41 <label>
42 <input id="delete-cookies-checkbox" 42 <input id="delete-cookies-checkbox"
43 pref="browser.clear_data.cookies" type="checkbox"> 43 pref="browser.clear_data.cookies" type="checkbox"
44 aria-controls="delete-cookies-counter">
msramek 2017/01/09 12:54:44 I don't think it was the right decision, but anywa
dullweber 2017/01/09 16:05:46 Ok, I reverted this
44 <span i18n-content="deleteCookiesFlashCheckbox" 45 <span i18n-content="deleteCookiesFlashCheckbox"
45 class="clear-plugin-lso-data-enabled"></span> 46 class="clear-plugin-lso-data-enabled"></span>
46 <span i18n-content="deleteCookiesCheckbox" 47 <span>
47 class="clear-plugin-lso-data-disabled"></span> 48 <span i18n-content="deleteCookiesCheckbox"
49 class="clear-plugin-lso-data-disabled"></span>
50 <span class="clear-browser-data-counter" role="note"
51 aria-live="polite" id="delete-cookies-counter"></span>
52 </span>
48 </label> 53 </label>
49 </div> 54 </div>
50 <div id="delete-cache-container" class="checkbox"> 55 <div id="delete-cache-container" class="checkbox">
51 <label> 56 <label>
52 <input id="delete-cache-checkbox" 57 <input id="delete-cache-checkbox"
53 pref="browser.clear_data.cache" type="checkbox" 58 pref="browser.clear_data.cache" type="checkbox"
54 aria-controls="delete-cache-counter"> 59 aria-controls="delete-cache-counter">
55 <span> 60 <span>
56 <span i18n-content="deleteCacheCheckbox"></span> 61 <span i18n-content="deleteCacheCheckbox"></span>
57 <span class="clear-browser-data-counter" role="note" 62 <span class="clear-browser-data-counter" role="note"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 <p id="clear-browser-data-history-footer" 133 <p id="clear-browser-data-history-footer"
129 i18n-values=".innerHTML:clearBrowserDataHistoryFooter" hidden></p> 134 i18n-values=".innerHTML:clearBrowserDataHistoryFooter" hidden></p>
130 <p id="clear-browser-data-general-footer"> 135 <p id="clear-browser-data-general-footer">
131 <span><!--This is filled by JavaScript--></span> 136 <span><!--This is filled by JavaScript--></span>
132 <a id="clear-browser-data-footer-learn-more-link" hidden 137 <a id="clear-browser-data-footer-learn-more-link" hidden
133 target="_blank" i18n-content="learnMore" 138 target="_blank" i18n-content="learnMore"
134 i18n-values="href:clearBrowsingDataLearnMoreUrl"></a> 139 i18n-values="href:clearBrowsingDataLearnMoreUrl"></a>
135 </p> 140 </p>
136 </div> 141 </div>
137 </div> 142 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698