Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Issue 2594693002: Use grey_replaceText now that an EG bug is fixed
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm b/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
index 33a33661a58740db68dbfb1399d92ce19c6b53f5..f2fdf8f7a9d638b2ca282de31108efc94fa70e41 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
+++ b/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
@@ -627,26 +627,14 @@ id<GREYMatcher> actionSheet(Action action) {
performAction:grey_tap()];
// Replace the title field with new text.
- // TODO(crbug.com/644730): Use grey_replaceText instead of
- // grey_clearText/grey_typeText when EarlGrey's issue is fixed:
- // https://github.com/google/EarlGrey/issues/253
[[EarlGrey
selectElementWithMatcher:grey_accessibilityID(@"Title Field_textField")]
- performAction:grey_clearText()];
- [[EarlGrey
- selectElementWithMatcher:grey_accessibilityID(@"Title Field_textField")]
- performAction:grey_typeText(@"n5")];
+ performAction:grey_replaceText(@"n5")];
// Replace the url field with new text.
- // TODO(crbug.com/644730): Use grey_replaceText instead of
- // grey_clearText/grey_typeText when EarlGrey's issue is fixed:
- // https://github.com/google/EarlGrey/issues/253
- [[EarlGrey
- selectElementWithMatcher:grey_accessibilityID(@"URL Field_textField")]
- performAction:grey_clearText()];
[[EarlGrey
selectElementWithMatcher:grey_accessibilityID(@"URL Field_textField")]
- performAction:grey_typeText(@"www.a.fr")];
+ performAction:grey_replaceText(@"www.a.fr")];
// Dismiss editor.
[[EarlGrey selectElementWithMatcher:bookmarksDoneButton()]
@@ -676,26 +664,14 @@ id<GREYMatcher> actionSheet(Action action) {
performAction:grey_tap()];
// Replace the title field with new text.
- // TODO(crbug.com/644730): Use grey_replaceText instead of
- // grey_clearText/grey_typeText when EarlGrey's issue is fixed:
- // https://github.com/google/EarlGrey/issues/253
- [[EarlGrey
- selectElementWithMatcher:grey_accessibilityID(@"Title Field_textField")]
- performAction:grey_clearText()];
[[EarlGrey
selectElementWithMatcher:grey_accessibilityID(@"Title Field_textField")]
- performAction:grey_typeText(@"n5")];
+ performAction:grey_replaceText(@"n5")];
// Replace the url field with new text.
- // TODO(crbug.com/644730): Use grey_replaceText instead of
- // grey_clearText/grey_typeText when EarlGrey's issue is fixed:
- // https://github.com/google/EarlGrey/issues/253
[[EarlGrey
selectElementWithMatcher:grey_accessibilityID(@"URL Field_textField")]
- performAction:grey_clearText()];
- [[EarlGrey
- selectElementWithMatcher:grey_accessibilityID(@"URL Field_textField")]
- performAction:grey_typeText(@"www.a.fr")];
+ performAction:grey_replaceText(@"www.a.fr")];
// Dismiss editor with Cancel button.
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Cancel")]
@@ -752,13 +728,8 @@ id<GREYMatcher> actionSheet(Action action) {
performAction:grey_tap()];
// Change the title.
- // TODO(crbug.com/644730): Use grey_replaceText instead of
- // grey_clearText/grey_typeText when EarlGrey's issue is fixed:
- // https://github.com/google/EarlGrey/issues/253
- [[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Title_textField")]
- performAction:grey_clearText()];
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Title_textField")]
- performAction:grey_typeText(@"Renamed Folder")];
+ performAction:grey_replaceText(@"Renamed Folder")];
// Cancel without saving.
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Cancel")]
@@ -774,13 +745,8 @@ id<GREYMatcher> actionSheet(Action action) {
performAction:grey_tap()];
// Change the title.
- // TODO(crbug.com/644730): Use grey_replaceText instead of
- // grey_clearText/grey_typeText when EarlGrey's issue is fixed:
- // https://github.com/google/EarlGrey/issues/253
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Title_textField")]
- performAction:grey_clearText()];
- [[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Title_textField")]
- performAction:grey_typeText(@"Renamed Folder")];
+ performAction:grey_replaceText(@"Renamed Folder")];
// Save.
[[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Save")]
@@ -1369,15 +1335,9 @@ id<GREYMatcher> actionSheet(Action action) {
// Change the name of the folder.
if (name.length > 0) {
- // TODO(crbug.com/644730): Use grey_replaceText instead of
- // grey_clearText/grey_typeText when EarlGrey's issue is fixed:
- // https://github.com/google/EarlGrey/issues/253
- [[EarlGrey
- selectElementWithMatcher:grey_accessibilityID(@"Title_textField")]
- performAction:grey_clearText()];
[[EarlGrey
selectElementWithMatcher:grey_accessibilityID(@"Title_textField")]
- performAction:grey_typeText(name)];
+ performAction:grey_replaceText(name)];
}
// Tap the Save button.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698