Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/Source/BUILD.gn

Issue 2594603002: Add a GN option to use Chromium style naming with the Blink GC plugin. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/BUILD.gn
diff --git a/third_party/WebKit/Source/BUILD.gn b/third_party/WebKit/Source/BUILD.gn
index 0218e80a9737225f9e9bf7e644481fa882ce3a5b..f862546e93afbd93ad0ebc2f617a093088d6cc56 100644
--- a/third_party/WebKit/Source/BUILD.gn
+++ b/third_party/WebKit/Source/BUILD.gn
@@ -24,6 +24,11 @@ declare_args() {
# a class has an empty destructor which would be unnecessarily invoked
# when finalized.
blink_gc_plugin_option_warn_unneeded_finalizer = false
+
+ # Set to true to have the clang Blink GC plugin use Chromium-style naming
+ # rather than legacy Blink name.
+ # TODO(https://crbug.com/675879): Remove this option after the Blink rename.
+ blink_gc_plugin_option_use_chromium_style_naming = false
}
# features ---------------------------------------------------------------------
@@ -149,6 +154,14 @@ config("config") {
"warn-unneeded-finalizer",
]
}
+ if (blink_gc_plugin_option_use_chromium_style_naming) {
+ cflags += [
+ "-Xclang",
+ "-plugin-arg-blink-gc-plugin",
+ "-Xclang",
+ "use-chromium-style-naming",
+ ]
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698