Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 259443002: Revert of Make data: urls always parse async (Closed)

Created:
6 years, 8 months ago by aboxhall
Modified:
6 years, 8 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Revert of Make data: urls always parse async (https://codereview.chromium.org/210253003/) Reason for revert: Seems to have broken many browser_tests: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2364/steps/browser_tests/logs/stdio http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/18723/steps/browser_tests%20%28with%20patch%29 Original issue's description: > Make data: urls always parse async > > Turns out Chrome has long had the behavior of issuing > loads and delivering load events async for data: urls, > but not actually doing the parsing async. This changes > makes the parsing of data:text/html content always async. > > NOTE: The new async test (loader/iframe-sync-loads.html) > does not change before before/after this test, it's > there to confirm that we were already behaving async > with regards to when the content appeared in the iframe. > > This finally makes it possible to take a JS string > and run it through the HTML parser async. I'll fix > <iframe srcdoc> to also be async in a follow-up patch. > > I wrote a test to check sync/async behavior of various > loading methods for iframes. Gecko has async behavior > for all 3 of these cases in my test, where as Chrome > on Linux has sync behavior for javascript: > > This is covered by 3 additional tests: > fast/dom/document-contentType-data-uri.html: > - text/html content is now async, matches FF > > accessibility/loading-iframe-sends-notification.html > - had to re-write this test to not assume that the iframe > would be laid out before its onload was fired. > > scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html > - This was hitting crbug.com/365509 which I worked around by > calling setUseMockScrollbars earlier. > > BUG=308321, 365509 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172401 TBR=abarth@chromium.org,japhet@chromium.org,dmazzoni@chromium.org,eseidel@chromium.org NOTREECHECKS=true NOTRY=true BUG=308321, 365509 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -97 lines) Patch
M LayoutTests/accessibility/loading-iframe-sends-notification.html View 1 chunk +23 lines, -17 lines 0 comments Download
M LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/document-contentType-data-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/drag-and-drop-autoscroll-inner-frame.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/html5lib/resources/runner.js View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/loader/iframe-sync-loads.html View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/loader/iframe-sync-loads-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/scrollingcoordinator/resources/non-fast-scrollable-region-testing.js View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/HTMLParserOptions.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
aboxhall
Created Revert of Make data: urls always parse async
6 years, 8 months ago (2014-04-23 23:08:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/259443002/1
6 years, 8 months ago (2014-04-23 23:08:23 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 23:09:22 UTC) #3
Message was sent while issue was closed.
Change committed as 172426

Powered by Google App Engine
This is Rietveld 408576698