Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2594413002: Reland: Make File.create() fail when a directory exists at the same path (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland: Make File.create() fail when a directory exists at the same path related #28170 Committed: https://github.com/dart-lang/sdk/commit/2ad9b921be22dfee34c2d12cf0d4066ab426613c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -12 lines) Patch
M runtime/bin/file_android.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 2 chunks +22 lines, -5 lines 0 comments Download
M runtime/bin/file_linux.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M runtime/bin/file_macos.cc View 2 chunks +18 lines, -2 lines 0 comments Download
A tests/standalone/io/file_create_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years ago (2016-12-22 16:12:32 UTC) #2
zra
TBR
4 years ago (2016-12-22 16:12:47 UTC) #3
zra
Committed patchset #1 (id:1) manually as 2ad9b921be22dfee34c2d12cf0d4066ab426613c (presubmit successful).
4 years ago (2016-12-22 16:13:02 UTC) #5
Cutch
4 years ago (2016-12-22 17:34:42 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698