third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h - Issue 2594353003: Crash in blink::beforeCallEnteredCallback()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

Issue 2594353003: Crash in blink::beforeCallEnteredCallback() (Closed)

Patch Set: Updated after review Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

index e64369c12b93fa1514c26b7378d3ec445e4bf4ba..20ce083af5400b7ff745c4f7b477e74c0b2cd67a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h

@@ -126,6 +126,9 @@ class CORE_EXPORT ScriptPromiseResolver

m_state = newState;

ScriptState::Scope scope(m_scriptState.get());

+ // TODO(aobzhirov): Converting value to the wrapper can trigger assert

+ // if the script is forbidden.

+ // The script check below will be unreachable in this case.

m_value.set(m_scriptState->isolate(),

ToV8(value, m_scriptState->context()->Global(),

m_scriptState->isolate()));