third_party/WebKit/LayoutTests/media/crash-in-media-moved-to-newdocument.html - Issue 2594353003: Crash in blink::beforeCallEnteredCallback()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/crash-in-media-moved-to-newdocument.html

Issue 2594353003: Crash in blink::beforeCallEnteredCallback() (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <iframe width=400 height=300></iframe>

	5 <script>

	6 test(() => {

	7 var media = document.createElement('video');

	8 media.src = 'nosuchurl';

	9

	10 var promise = media.play();

	11 if (promise != undefined) {
	mlamouri (slow - plz ping) 2016/12/23 12:00:26 I don't think you need this, it will return a prom I don't think you need this, it will return a promise. Just do: `media.play().then()` Anton Obzhirov 2017/01/09 15:35:54 ok Show quoted text On 2016/12/23 12:00:26, mlamouri wrote: > I don't think you need this, it will return a promise. Just do: > `media.play().then()` ok
	12 promise.then(() => {

	13 }).catch((error) => {

	14 });
	mlamouri (slow - plz ping) 2016/12/23 12:00:26 Can you make this an async_test and add unreach on Can you make this an async_test and add unreach on the non-expected path and t.done() on the other. Anton Obzhirov 2017/01/09 15:35:54 Will do. Show quoted text On 2016/12/23 12:00:26, mlamouri wrote: > Can you make this an async_test and add unreach on the non-expected path and > t.done() on the other. Will do.
	15 }

	16 window.frames[0].document.body.appendChild(media);

	17 }, "Test for crbug/676004: Crash in blink::beforeCallEnteredCallback()");

	18 </script>

OLD	NEW