Support accessible inline text boxes.

content/renderer/accessibility/accessibility_node_serializer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/accessibility/accessibility_node_serializer.h"
 
 #include <set>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 133 matching lines @@
   }
 
   if (dst->role == WebKit::WebAXRoleColorWell) {
     int r, g, b;
     src.colorValue(r, g, b);
     dst->AddIntAttribute(dst->ATTR_COLOR_VALUE_RED, r);
     dst->AddIntAttribute(dst->ATTR_COLOR_VALUE_GREEN, g);
     dst->AddIntAttribute(dst->ATTR_COLOR_VALUE_BLUE, b);
   }
 
+  if (dst->role == WebKit::WebAXRoleInlineTextBox) {
+    dst->AddIntAttribute(dst->ATTR_TEXT_DIRECTION, src.textDirection());
+
+    WebVector<int> src_character_offsets;
+    src.characterOffsets(src_character_offsets);
+    std::vector<int32> character_offsets;
+    character_offsets.reserve(src_character_offsets.size());
+    for (size_t i = 0; i < src_character_offsets.size(); ++i)
+      character_offsets.push_back(src_character_offsets[i]);
+    dst->AddIntListAttribute(dst->ATTR_CHARACTER_OFFSETS, character_offsets);
+
+    WebVector<int> src_word_starts;
+    WebVector<int> src_word_ends;
+    src.wordBoundaries(src_word_starts, src_word_ends);
+    std::vector<int32> word_starts;
+    std::vector<int32> word_ends;
+    word_starts.reserve(src_word_starts.size());
+    word_ends.reserve(src_word_starts.size());
+    for (size_t i = 0; i < src_word_starts.size(); ++i) {
+      word_starts.push_back(src_word_starts[i]);
+      word_ends.push_back(src_word_ends[i]);
+    }
+    dst->AddIntListAttribute(dst->ATTR_WORD_STARTS, word_starts);
+    dst->AddIntListAttribute(dst->ATTR_WORD_ENDS, word_ends);

[David Tseng, 2013/10/17 22:56:29]

It seems like a good idea to perhaps have a few dump accessibility tree tests to
validate these attributes on the browser end.

[dmazzoni, 2013/10/21 17:26:57]

Agreed about testing these.

I don't want to use dump accessibility tree tests because the only native APIs
that make use of these attributes are "parameterized" apis, like boundsForRange,
lineForIndex, etc. - which aren't very easy to express in DumpAccessibilityTree
tests.

Perhaps we need to work on a new type of test that's almost as easy to write as
a DumpAccessibilityTree test but lets us query the resulting tree with different
arguments.

Or maybe we need a DumpAccessibilityTree "platform" for the cross-platform
representation.

My intent is to add the tests along with the code that makes use of each
attribute - just to keep the changes small. I have another change pending for
implementing boundsForRange, for example - and I'll send one that makes use of
the word boundaries soon. Is that reasonable?

+  }
+
   if (src.accessKey().length())
     dst->AddStringAttribute(dst->ATTR_ACCESS_KEY, UTF16ToUTF8(src.accessKey()));
   if (src.actionVerb().length())
     dst->AddStringAttribute(dst->ATTR_ACTION, UTF16ToUTF8(src.actionVerb()));
   if (src.isAriaReadOnly())
     dst->AddBoolAttribute(dst->ATTR_ARIA_READONLY, true);
   if (src.isButtonStateMixed())
     dst->AddBoolAttribute(dst->ATTR_BUTTON_MIXED, true);
   if (src.canSetValueAttribute())
     dst->AddBoolAttribute(dst->ATTR_CAN_SET_VALUE, true);
@@ skipping 298 matching lines @@
   WebNode node = parent.node();
   if (!node.isNull() && node.isElementNode()) {
     WebElement element = node.to<WebElement>();
     is_iframe = (element.tagName() == ASCIIToUTF16("IFRAME"));
   }
 
   return (is_iframe || IsParentUnignoredOf(parent, child));
 }
 
 }  // namespace content