Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2594203004: Unifying ChildProcessLauncher across platforms. (Closed)
Patch Set: Clean-up. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 4fb8c880ae41d0bb755c471400c21ea5eb284e46..986b30c2e5de6ba2eccd245b318c251e80c344a7 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -198,7 +198,6 @@
#include "ui/native_theme/native_theme_switches.h"
#if defined(OS_ANDROID)
-#include "content/browser/android/child_process_launcher_android.h"
#include "content/browser/screen_orientation/screen_orientation_listener_android.h"
#include "content/public/browser/android/java_interfaces.h"
#include "ipc/ipc_sync_channel.h"
@@ -1939,16 +1938,10 @@ bool RenderProcessHostImpl::Shutdown(int exit_code, bool wait) {
if (run_renderer_in_process())
return false; // Single process mode never shuts down the renderer.
-#if defined(OS_ANDROID)
- // Android requires a different approach for killing.
- StopChildProcess(GetHandle());
- return true;
-#else
- if (!child_process_launcher_.get() || child_process_launcher_->IsStarting())
+ if (!child_process_launcher_.get())
return false;
- return child_process_launcher_->GetProcess().Terminate(exit_code, wait);
-#endif
+ return child_process_launcher_->Terminate(exit_code, wait);
}
bool RenderProcessHostImpl::FastShutdownIfPossible() {
« no previous file with comments | « content/browser/file_descriptor_info_impl_unittest.cc ('k') | content/public/browser/browser_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698