Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: content/browser/android/child_process_launcher_android.h

Issue 2594203004: Unifying ChildProcessLauncher across platforms. (Closed)
Patch Set: Clean-up. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/android/child_process_launcher_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/child_process_launcher_android.h
diff --git a/content/browser/android/child_process_launcher_android.h b/content/browser/android/child_process_launcher_android.h
index 78f088a6c5a743fb4e8a83e4aa8dd6e89c264bab..2f498ac236da69dec38378dfacae93f79aa3dd1e 100644
--- a/content/browser/android/child_process_launcher_android.h
+++ b/content/browser/android/child_process_launcher_android.h
@@ -7,40 +7,38 @@
#include <jni.h>
-#include <map>
-#include <memory>
-
-#include "base/android/scoped_java_ref.h"
#include "base/callback.h"
#include "base/command_line.h"
-#include "base/files/memory_mapped_file.h"
#include "base/process/process.h"
#include "content/public/browser/file_descriptor_info.h"
-#include "ui/gl/android/scoped_java_surface.h"
+// Contains the methods either being called from or calling to
+// ChildProcessLauncher.java.
namespace content {
-typedef base::Callback<void(base::ProcessHandle)> StartChildProcessCallback;
-// Starts a process as a child process spawned by the Android
-// ActivityManager.
+
+typedef base::Callback<void(base::ProcessHandle, int /* launch result */)>
+ StartChildProcessCallback;
+
+// Starts a process as a child process spawned by the Android ActivityManager.
// The created process handle is returned to the |callback| on success, 0 is
// returned if the process could not be created.
void StartChildProcess(
const base::CommandLine::StringVector& argv,
int child_process_id,
- const std::unique_ptr<FileDescriptorInfo> files_to_register,
+ FileDescriptorInfo* files_to_register,
const StartChildProcessCallback& callback);
-// Stops a child process based on the handle returned form
-// StartChildProcess.
+// Stops a child process based on the handle returned from StartChildProcess.
void StopChildProcess(base::ProcessHandle handle);
bool IsChildProcessOomProtected(base::ProcessHandle handle);
void SetChildProcessInForeground(base::ProcessHandle handle,
bool in_foreground);
+
bool RegisterChildProcessLauncher(JNIEnv* env);
} // namespace content
-#endif // CONTENT_BROWSER_ANDROID_CHILD_PROCESS_LAUNCHER_ANDROID_H_
+#endif // CONTENT_BROWSER_ANDROID_CHILD_PROCESS_LAUNCHER_ANDROID_H_
« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/android/child_process_launcher_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698