Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 25942002: Make software compositing work on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows resolve Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.h
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.h b/content/browser/renderer_host/render_widget_host_view_aura.h
index 77b5db4fe7ae1998fea0d2a604aad06539a7470c..f333eed33b0e013051235ce185ae8371b83f8618 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.h
+++ b/content/browser/renderer_host/render_widget_host_view_aura.h
@@ -20,8 +20,8 @@
#include "cc/resources/texture_mailbox.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
#include "content/browser/aura/image_transport_factory.h"
-#include "content/browser/renderer_host/frame_memory_manager.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
+#include "content/browser/renderer_host/software_frame_manager.h"
#include "content/common/content_export.h"
#include "content/common/gpu/client/gl_helper.h"
#include "third_party/skia/include/core/SkRegion.h"
@@ -59,7 +59,6 @@ class Texture;
}
namespace content {
-class MemoryHolder;
class RenderWidgetHostImpl;
class RenderWidgetHostView;
class ResizeLock;
@@ -78,7 +77,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
public aura::client::CursorClientObserver,
public ImageTransportFactoryObserver,
public BrowserAccessibilityDelegate,
- public FrameContainer,
+ public SoftwareFrameManagerClient,
public base::SupportsWeakPtr<RenderWidgetHostViewAura>,
public cc::DelegatedFrameResourceCollectionClient {
public:
@@ -332,8 +331,10 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
virtual void OnRootWindowHostMoved(const aura::RootWindow* root,
const gfx::Point& new_origin) OVERRIDE;
- // FrameContainer implementation:
- virtual void ReleaseCurrentFrame() OVERRIDE;
+ // SoftwareFrameManagerClient implementation:
+ virtual void SoftwareFrameWasFreed(
+ uint32 output_surface_id, unsigned frame_id) OVERRIDE;
+ virtual void ReleaseReferencesToSoftwareFrame() OVERRIDE;
bool CanCopyToBitmap() const;
@@ -613,8 +614,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
// The current frontbuffer texture.
scoped_refptr<ui::Texture> current_surface_;
- // This holds the current software framebuffer.
- scoped_refptr<MemoryHolder> framebuffer_holder_;
+ // This holds the current software framebuffer, if any.
+ scoped_ptr<SoftwareFrameManager> software_frame_manager_;
// With delegated renderer, this is the last output surface, used to
// disambiguate resources with the same id coming from different output
@@ -754,6 +755,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAura
};
scoped_ptr<ReleasedFrameInfo> released_software_frame_;
+ base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura);
};
« no previous file with comments | « content/browser/renderer_host/frame_memory_manager.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698