Only use host() for chrome:// urls in EventListener

extensions/browser/event_listener_map.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/event_listener_map.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 19 matching lines @@
   return base::WrapUnique(new EventListener(event_name, extension_id, GURL(),
                                             process, std::move(filter)));
 }
 
 // static
 std::unique_ptr<EventListener> EventListener::ForURL(
     const std::string& event_name,
     const GURL& listener_url,
     content::RenderProcessHost* process,
     std::unique_ptr<base::DictionaryValue> filter) {
-  return base::WrapUnique(new EventListener(event_name, "", listener_url,
-                                            process, std::move(filter)));
+  return base::WrapUnique(new EventListener(

[Dan Beam, 2016/12/22 01:51:19]

nit: MakeUnique<EventListener>(...)

[stevenjb, 2016/12/22 01:55:29]

WrapUnique is used here because the constructor is private, and I'm not going to
change that here.

[Dan Beam, 2016/12/22 01:57:18]

ah, fair

+      event_name, "", listener_url.GetOrigin(), process, std::move(filter)));

[Devlin, 2016/12/22 16:01:09]

let's add a comment saying why we do this.

[stevenjb, 2016/12/22 19:06:05]

Done.

 }
 
 EventListener::~EventListener() {}
 
 bool EventListener::Equals(const EventListener* other) const {
   // We don't check matcher_id equality because we want a listener with a
   // filter that hasn't been added to EventFilter to match one that is
   // equivalent but has.
   return event_name_ == other->event_name_ &&
          extension_id_ == other->extension_id_ &&
@@ skipping 226 matching lines @@
     return;
   event_filter_.RemoveEventMatcher(listener->matcher_id());
   CHECK_EQ(1u, listeners_by_matcher_id_.erase(listener->matcher_id()));
 }
 
 bool EventListenerMap::IsFilteredEvent(const Event& event) const {
   return filtered_events_.count(event.event_name) > 0u;
 }
 
 }  // namespace extensions