Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2594173002: Reland of Disable dromaeo.jslibmodifyjquery on Windows (Closed)

Created:
4 years ago by martiniss
Modified:
4 years ago
CC:
chromium-reviews, nednguyen, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2562493002/ ) Reason for revert: Still failing on windows. Original issue's description: > Revert of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2557513006/ ) > > Reason for revert: > Another fix landed in V8 5.7.155. https://codereview.chromium.org/2551973005/ > > Trying again > > Original issue's description: > > Reland of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2532653002/ ) > > > > Reason for revert: > > Still failing with wrapper tracing. Investigating. > > > > Original issue's description: > > > Revert of Disable dromaeo.jslibmodifyjquery on Windows (patchset #1 id:1 of https://codereview.chromium.org/2529673003/ ) > > > > > > Reason for revert: > > > Re-enable tests as we fixed a problem with wrapper tracing. > > > > > > Original issue's description: > > > > Disable dromaeo.jslibmodifyjquery on Windows > > > > > > > > R=sullivan@chromium.org > > > > BUG=668164 > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > > > > > > > Committed: https://crrev.com/98679f8f94d5beb4b7a0715edef85f8ba250f34b > > > > Cr-Commit-Position: refs/heads/master@{#434268} > > > > > > TBR=sullivan@chromium.org,fmeawad@chromium.org > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > BUG=668164 > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > > > > > Committed: https://crrev.com/d74a3000970f43efa51287a3f7f5931abdfa1437 > > > Cr-Commit-Position: refs/heads/master@{#434704} > > > > TBR=sullivan@chromium.org,fmeawad@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=668164 > > > > Committed: https://crrev.com/6c485a2cf894fd6761fcd3e5ea4905ce773b96b5 > > Cr-Commit-Position: refs/heads/master@{#436918} > > TBR=sullivan@chromium.org,fmeawad@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=668164 > > Committed: https://crrev.com/61aaba1d8be432e52687ea4ff207342189d5d15d > Cr-Commit-Position: refs/heads/master@{#437015} TBR=sullivan@chromium.org,fmeawad@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=668164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/perf/benchmarks/dromaeo.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
martiniss
Created Reland of Disable dromaeo.jslibmodifyjquery on Windows
4 years ago (2016-12-21 22:50:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594173002/1
4 years ago (2016-12-21 22:50:43 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-21 22:50:44 UTC) #5
martiniss
On 2016/12/21 at 22:50:09, martiniss wrote: > Created Reland of Disable dromaeo.jslibmodifyjquery on Windows FTR, ...
4 years ago (2016-12-21 22:51:15 UTC) #6
martiniss
Need LGTM from a committer.
4 years ago (2016-12-21 22:51:24 UTC) #7
sullivan
lgtm
4 years ago (2016-12-21 22:52:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594173002/1
4 years ago (2016-12-21 22:53:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/127000) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-21 22:55:12 UTC) #12
martiniss
4 years ago (2016-12-21 22:59:52 UTC) #13

Powered by Google App Engine
This is Rietveld 408576698