Fix bug in DocumentMarkerController::addMarker(Node* node, const DocumentMarker& newMarker)

Fix bug in DocumentMarkerController::addMarker(Node* node, const DocumentMarker& newMarker)

Basically it's doing a vector insert when it should be doing an element
assignment. See crbug.com/676445 for details

BUG=676445
Committed: https://chromium.googlesource.com/chromium/src/+/23142d0b7ace418a54fb65bbb9be72ac4e79be86

[rlanday, 2016-12-21 22:15:22]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 22:15:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2016-12-21 22:15:57]

rlanday@chromium.org changed reviewers:
+ ojan@chromium.org, yosin@chromium.org, yutak@chromium.org

[rlanday, 2016-12-21 22:16:52]

One-line bug fix for DocumentMarkerController::addMarker()

[commit-bot: I haz the power, 2016-12-21 23:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 23:49:18]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-05 06:32:16]

lgtm

Thanks for finding this!

To reproduce this, find something to misspelled (TextMatchMarkerIndex = 3), then
adding miss spelled marker (SpellingMarkerIndex = 0), then TextMatcherMarker
list is moved to markers[4] by WTF::Vector::insert()

[rlanday, 2017-01-05 18:19:58]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:20:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 20:01:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483640398819230, "parent_rev":
"912bfe0a6472b47cec3271f2e9f21f0a3f9074c1", "commit_rev":
"23142d0b7ace418a54fb65bbb9be72ac4e79be86"}

[commit-bot: I haz the power, 2017-01-05 20:07:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:07:54]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[tandrii(chromium), 2017-01-05 20:21:38]

On 2017/01/05 20:07:54, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

It actually has been committed as
https://chromium.googlesource.com/chromium/src/+/23142d0b7ace418a54fb65bbb9be...

[tandrii(chromium), 2017-01-05 20:22:08]

Description was changed from

==========
Fix bug in DocumentMarkerController::addMarker(Node* node, const DocumentMarker&
newMarker)

Basically it's doing a vector insert when it should be doing an element
assignment. See crbug.com/676445 for details

BUG=676445
==========

to

==========
Fix bug in DocumentMarkerController::addMarker(Node* node, const DocumentMarker&
newMarker)

Basically it's doing a vector insert when it should be doing an element
assignment. See crbug.com/676445 for details

BUG=676445
Committed:
https://chromium.googlesource.com/chromium/src/+/23142d0b7ace418a54fb65bbb9be...
==========