Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 259403003: [chromedriver] Add test extension for codereview.chromium.org/248253002. (Closed)

Created:
6 years, 7 months ago by samuong
Modified:
6 years, 7 months ago
Reviewers:
stgao
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[chromedriver] Add test extension for codereview.chromium.org/248253002. BUG=chromedriver:776 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A + chrome/test/data/chromedriver/ext_test_1.zip View Binary file 0 comments Download

Messages

Total messages: 7 (0 generated)
samuong
6 years, 7 months ago (2014-04-29 21:04:20 UTC) #1
stgao
lgtm, but please update the bug in the description as I moved it to chromedriver ...
6 years, 7 months ago (2014-04-29 21:08:24 UTC) #2
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 7 months ago (2014-04-29 21:09:06 UTC) #3
samuong
The CQ bit was unchecked by samuong@chromium.org
6 years, 7 months ago (2014-04-29 21:09:56 UTC) #4
samuong
The CQ bit was checked by samuong@chromium.org
6 years, 7 months ago (2014-04-29 21:20:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/259403003/1
6 years, 7 months ago (2014-04-29 21:22:13 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 21:24:36 UTC) #7
Message was sent while issue was closed.
Change committed as 266964

Powered by Google App Engine
This is Rietveld 408576698