Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 25940002: Revert 226826 "This is a preliminary patch to auto-generate the ..." (Closed)

Created:
7 years, 2 months ago by tbarzic
Modified:
7 years, 2 months ago
Reviewers:
dhnishi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 226826 "This is a preliminary patch to auto-generate the ..." The change broke CrOS builders: chromeos-chrome-32.0.1660.0_alpha-r1: i686-pc-linux-gnu-g++.real: error: c/Release/obj/gen/chrome/common/extensions/api/_permission_features.cc: No such file or directory chromeos-chrome-32.0.1660.0_alpha-r1: i686-pc-linux-gnu-g++.real: fatal error: no input files chromeos-chrome-32.0.1660.0_alpha-r1: compilation terminated. > This is a preliminary patch to auto-generate the ID enum in APIPermission. > > permission_features.h: https://gist.github.com/DHNishi/2014be18e7912916ea25 > > permission_features.cc: https://gist.github.com/DHNishi/b78bc9588b2d7a46331d > > BUG=280286 > > Review URL: https://codereview.chromium.org/23594008 TBR=DHNishi@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -492 lines) Patch
D trunk/src/build/features_compile.gypi View 1 chunk +0 lines, -60 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/api.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/code.py View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/tools/json_schema_compiler/cpp_util.py View 2 chunks +0 lines, -19 lines 0 comments Download
D trunk/src/tools/json_schema_compiler/features_cc_generator.py View 1 chunk +0 lines, -95 lines 0 comments Download
D trunk/src/tools/json_schema_compiler/features_compiler.py View 1 chunk +0 lines, -76 lines 0 comments Download
D trunk/src/tools/json_schema_compiler/features_h_generator.py View 1 chunk +0 lines, -95 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/model.py View 17 chunks +0 lines, -58 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/schema_loader.py View 1 chunk +3 lines, -0 lines 0 comments Download
D trunk/src/tools/json_schema_compiler/test/features_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M trunk/src/tools/json_schema_compiler/test/json_schema_compiler_tests.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D trunk/src/tools/json_schema_compiler/test/test_features.json View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tbarzic
7 years, 2 months ago (2013-10-03 21:24:24 UTC) #1
tbarzic
Committed patchset #1 manually as r226851.
7 years, 2 months ago (2013-10-03 21:24:36 UTC) #2
tbarzic
7 years, 2 months ago (2013-10-03 21:26:08 UTC) #3
Message was sent while issue was closed.
On 2013/10/03 21:24:36, tbarzic wrote:
> Committed patchset #1 manually as r226851.

http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%...

Powered by Google App Engine
This is Rietveld 408576698