Make File.create() fail when a directory exists at the same path

Make File.create() fail when a directory exists at the same path

fixes #28170

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/f2604a3647fce4f0a6feac34ee152a3dc103acdd

[zra, 2016-12-21 22:49:25]

Description was changed from

==========
Make File.create() fail when a directory exists at the same path
==========

to

==========
Make File.create() fail when a directory exists at the same path

fixes #28170
==========

[zra, 2016-12-21 22:50:57]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-12-21 23:00:47]

LGTM. It's too bad we have so much copy-and-pasted code in our file_xxx.cc
files.

[zra, 2016-12-21 23:12:21]

On 2016/12/21 23:00:47, Cutch wrote:
> LGTM. It's too bad we have so much copy-and-pasted code in our file_xxx.cc
> files.

Yes.

[zra, 2016-12-21 23:19:28]

Description was changed from

==========
Make File.create() fail when a directory exists at the same path

fixes #28170
==========

to

==========
Make File.create() fail when a directory exists at the same path

fixes #28170

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f2604a3647fce4f0a6feac34ee152a3dc103acdd
==========

[zra, 2016-12-21 23:19:29]

Committed patchset #2 (id:20001) manually as
f2604a3647fce4f0a6feac34ee152a3dc103acdd (presubmit successful).

[kasperl, 2016-12-22 08:24:39]

kasperl@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2016-12-22 08:24:40]

Can you find another way of testing this? It's causing issues on the build bots
(non-English locales).

https://codereview.chromium.org/2593913003/diff/20001/tests/standalone/io/fil...
File tests/standalone/io/file_create_test.dart (right):

https://codereview.chromium.org/2593913003/diff/20001/tests/standalone/io/fil...
tests/standalone/io/file_create_test.dart:37:
Expect.isTrue(e.toString().contains('Access is denied'));
This is going to fail in non-English locales.