Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: build/android/pylib/local/device/local_device_perf_test_run.py

Issue 2593903002: [android] Use contextlib_ext.Optional for conditional context managers. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_perf_test_run.py
diff --git a/build/android/pylib/local/device/local_device_perf_test_run.py b/build/android/pylib/local/device/local_device_perf_test_run.py
index 799dedce228ad9d11f22feb6ca6c4e51e4034d13..fd5d2b047f57ff49bcf57eaeb6a6335c432da018 100644
--- a/build/android/pylib/local/device/local_device_perf_test_run.py
+++ b/build/android/pylib/local/device/local_device_perf_test_run.py
@@ -3,7 +3,6 @@
# found in the LICENSE file.
import collections
-import contextlib
import io
import json
import logging
@@ -31,6 +30,7 @@ from pylib.constants import host_paths
from pylib.local.device import local_device_environment
from pylib.local.device import local_device_test_run
from py_trace_event import trace_event
+from py_utils import contextlib_ext
class HeartBeat(object):
@@ -96,20 +96,12 @@ class TestShard(object):
self._LogTest(test, cmd, timeout)
- @contextlib.contextmanager
- def trace_if_enabled(test):
- try:
- if self._test_instance.trace_output:
- trace_event.trace_begin(test)
- yield
- finally:
- if self._test_instance.trace_output:
- trace_event.trace_end(test)
-
try:
start_time = time.time()
- with trace_if_enabled(test):
+ with contextlib_ext.Optional(
+ trace_event.trace(test),
+ self._test_instance.trace_output):
exit_code, output = cmd_helper.GetCmdStatusAndOutputWithTimeout(
cmd, timeout, cwd=cwd, shell=True)
end_time = time.time()

Powered by Google App Engine
This is Rietveld 408576698