Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 2593793002: Remove call to WasHidden as part of the app being backgrounded. (Closed)
Patch Set: add comment Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_ OBSERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 ~DataReductionProxyMetricsObserver() override; 52 ~DataReductionProxyMetricsObserver() override;
53 53
54 // page_load_metrics::PageLoadMetricsObserver: 54 // page_load_metrics::PageLoadMetricsObserver:
55 ObservePolicy OnStart(content::NavigationHandle* navigation_handle, 55 ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
56 const GURL& currently_committed_url, 56 const GURL& currently_committed_url,
57 bool started_in_foreground) override; 57 bool started_in_foreground) override;
58 ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override; 58 ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
59 ObservePolicy OnHidden( 59 ObservePolicy OnHidden(
60 const page_load_metrics::PageLoadTiming& timing, 60 const page_load_metrics::PageLoadTiming& timing,
61 const page_load_metrics::PageLoadExtraInfo& info) override; 61 const page_load_metrics::PageLoadExtraInfo& info) override;
62 ObservePolicy FlushMetricsOnAppEnterBackground(
63 const page_load_metrics::PageLoadTiming& timing,
64 const page_load_metrics::PageLoadExtraInfo& info) override;
62 void OnComplete(const page_load_metrics::PageLoadTiming& timing, 65 void OnComplete(const page_load_metrics::PageLoadTiming& timing,
63 const page_load_metrics::PageLoadExtraInfo& info) override; 66 const page_load_metrics::PageLoadExtraInfo& info) override;
64 void OnDomContentLoadedEventStart( 67 void OnDomContentLoadedEventStart(
65 const page_load_metrics::PageLoadTiming& timing, 68 const page_load_metrics::PageLoadTiming& timing,
66 const page_load_metrics::PageLoadExtraInfo& info) override; 69 const page_load_metrics::PageLoadExtraInfo& info) override;
67 void OnLoadEventStart( 70 void OnLoadEventStart(
68 const page_load_metrics::PageLoadTiming& timing, 71 const page_load_metrics::PageLoadTiming& timing,
69 const page_load_metrics::PageLoadExtraInfo& info) override; 72 const page_load_metrics::PageLoadExtraInfo& info) override;
70 void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing, 73 void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing,
71 const page_load_metrics::PageLoadExtraInfo& info) override; 74 const page_load_metrics::PageLoadExtraInfo& info) override;
(...skipping 29 matching lines...) Expand all
101 104
102 // The browser context this navigation is operating in. 105 // The browser context this navigation is operating in.
103 content::BrowserContext* browser_context_; 106 content::BrowserContext* browser_context_;
104 107
105 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver); 108 DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
106 }; 109 };
107 110
108 } // namespace data_reduction_proxy 111 } // namespace data_reduction_proxy
109 112
110 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRI CS_OBSERVER_H_ 113 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRI CS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698