Issue 259373003: Mojo: Minor cleanup (of message_in_transit.cc and message_pipe.*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 259373003: Mojo: Minor cleanup (of message_in_transit.cc and message_pipe.*). (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Minor cleanup (of message_in_transit.cc and message_pipe.*). (Before I refactor message_in_transit.cc some more.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267111

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -120 lines)			Patch
M	mojo/system/channel.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/message_in_transit.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/system/message_in_transit.cc	View	4 chunks	+34 lines, -29 lines	0 comments	Download
M	mojo/system/message_pipe.h	View	2 chunks	+20 lines, -9 lines	0 comments	Download
M	mojo/system/message_pipe.cc	View	3 chunks	+84 lines, -79 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/259373003/1

6 years, 7 months ago (2014-04-29 21:28:25 UTC) #4

Message was sent while issue was closed.

Change committed as 267111

Expand Messages | Collapse Messages