android_webview/java/src/org/chromium/android_webview/AwCookieManager.java - Issue 2593653002: Split JNI init so native library preloading dosn't cause native init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwCookieManager.java

Issue 2593653002: Split JNI init so native library preloading dosn't cause native init. (Closed)

Patch Set: Add library initialization to AwCookieManager constructor Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/lib/main/webview_entry_point.cc » ('j') | base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwCookieManager.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwCookieManager.java b/android_webview/java/src/org/chromium/android_webview/AwCookieManager.java

index a4350dbf2d6e2a6579feaa36ef383e20d8cf631a..1b046041cc1dfc72be1f615a511b250bbdb2ea1f 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwCookieManager.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwCookieManager.java

@@ -10,6 +10,9 @@ import android.webkit.ValueCallback;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

+import org.chromium.base.library_loader.LibraryLoader;

+import org.chromium.base.library_loader.LibraryProcessType;

+import org.chromium.base.library_loader.ProcessInitException;

/**

* AwCookieManager manages cookies according to RFC2109 spec.

@@ -19,6 +22,14 @@ import org.chromium.base.annotations.JNINamespace;

@JNINamespace("android_webview")

public final class AwCookieManager {

+ public AwCookieManager() {

+ try {

+ LibraryLoader.get(LibraryProcessType.PROCESS_WEBVIEW).ensureInitialized();

Torne 2017/01/03 12:13:50 I'm guessing this is because cookie manager relies

Tobias Sargeant 2017/01/04 00:24:53 In comment #8 Robert pasted the exception in quest

+ } catch (ProcessInitException e) {

+ throw new RuntimeException("Error initializing WebView library", e);

+ }

/**

* Control whether cookie is enabled or disabled

* @param accept TRUE if accept cookie

« no previous file with comments | « no previous file | android_webview/lib/main/webview_entry_point.cc » ('j') | base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java » ('J')