Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/android/monochrome_entry_point.cc

Issue 2593653002: Split JNI init so native library preloading dosn't cause native init. (Closed)
Patch Set: Add library initialization to AwCookieManager constructor Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/lib/main/webview_jni_onload.h" 5 #include "android_webview/lib/main/webview_jni_onload.h"
6 #include "base/android/jni_android.h" 6 #include "base/android/jni_android.h"
7 #include "base/android/library_loader/library_loader_hooks.h" 7 #include "base/android/library_loader/library_loader_hooks.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "chrome/app/android/chrome_jni_onload.h" 9 #include "chrome/app/android/chrome_jni_onload.h"
10 10
11 namespace { 11 namespace {
12 12
13 bool RegisterJNI(JNIEnv* env) { 13 bool Init() {
14 return true; 14 return true;
15 } 15 }
16 16
17 bool Init() { 17 bool NativeInit() {
18 return true; 18 JNIEnv* env = base::android::AttachCurrentThread();
19 int library_process_type = base::android::GetLibraryProcessType(env);
20 switch (library_process_type) {
21 case base::android::PROCESS_WEBVIEW:
22 case base::android::PROCESS_WEBVIEW_CHILD:
23 return android_webview::OnJNIOnLoadInit();
24 break;
25 case base::android::PROCESS_BROWSER:
26 case base::android::PROCESS_CHILD:
27 return android::OnJNIOnLoadInit(base::Bind(&Init));
28 break;
29 default:
30 NOTREACHED();
31 return false;
32 }
19 } 33 }
20 34
21 } // namespace 35 } // namespace
22 36
23 // This is called by the VM when the shared library is first loaded. 37 // This is called by the VM when the shared library is first loaded.
24 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 38 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
39 base::android::DisableManualJniRegistration();
25 base::android::InitVM(vm); 40 base::android::InitVM(vm);
26 JNIEnv* env = base::android::AttachCurrentThread(); 41 base::android::SetNativeInitializationHook(NativeInit);
27 bool ret; 42 return JNI_VERSION_1_4;
28 int library_process_type = base::android::GetLibraryProcessType(env);
29 if (library_process_type == base::android::PROCESS_WEBVIEW ||
30 library_process_type == base::android::PROCESS_WEBVIEW_CHILD) {
31 base::android::DisableManualJniRegistration();
32 ret = android_webview::OnJNIOnLoadInit();
33 } else {
34 ret = android::OnJNIOnLoadRegisterJNI(vm, base::Bind(&RegisterJNI)) &&
35 android::OnJNIOnLoadInit(base::Bind(&Init));
36 }
37 return ret ? JNI_VERSION_1_4 : -1;
38 } 43 }
OLDNEW
« chrome/browser/android/chrome_entry_point.cc ('K') | « chrome/browser/android/chrome_entry_point.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698