Make Socket::connect try all addresses given.

sdk/lib/io/socket.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 
 /**
  * [InternetAddressType] is the type an [InternetAddress]. Currently,
  * IP version 4 (IPv4) and IP version 6 (IPv6) are supported.
@@ skipping 369 matching lines @@
    * This is a one-shot listener, and writeEventsEnabled must be set
    * to true again to receive another write event.
    */
   bool writeEventsEnabled;
 
   /**
    * Creates a new socket connection to the host and port and returns a [Future]
    * that will complete with either a [RawSocket] once connected or an error
    * if the host-lookup or connection failed.
    *
-   * [host] can either be a [String] or an [InternetAddress]. If [host] is a
-   * [String], [connect] will perform a [InternetAddress.lookup] and use
-   * the first value in the list.
+   * [host] can either be a [String], an [InternetAddress] or a [List] of

[Søren Gjesse, 2014/04/30 13:11:56]

we don't want to support a list of InternetAddress here. If a DNS-lookup happens
it will internally do this, but it should not be something the user can specify
directly. If one wants to do a DNS-lookup manually and want to try all or some
of the addresses that must be done with manual calls to connect.

[Anders Johnsen, 2014/05/01 06:31:23]

Done.

+   * [InternetAddress]es. If [host] is a
+   * [String], [connect] will perform a [InternetAddress.lookup] and try
+   * all returned [InternetAddress]es, in turn, until connected. If a connection
+   * was not possibly to any of the [InternetAddress]es, the error from the last

[Ivan Posva, 2014/04/30 16:28:06]

possibly -> possible

Or you might reword it a bit to say that you return the last error unless a
successful connection was made.

[Anders Johnsen, 2014/05/01 06:31:23]

Done.

+   * attempt is returned.
    */
   external static Future<RawSocket> connect(host, int port);
 
   /**
    * Returns the number of received and non-read bytes in the socket that
    * can be read.
    */
   int available();
 
   /**
@@ skipping 68 matching lines @@
  *
  * The [Socket] exposes both a [Stream] and a [IOSink] interface, making it
  * ideal for using together with other [Stream]s.
  */
 abstract class Socket implements Stream<List<int>>, IOSink {
   /**
    * Creats a new socket connection to the host and port and returns a [Future]
    * that will complete with either a [Socket] once connected or an error
    * if the host-lookup or connection failed.
    *
-   * [host] can either be a [String] or an [InternetAddress]. If [host] is a
-   * [String], [connect] will perform a [InternetAddress.lookup] and use
-   * the first value in the list.
+   * [host] can either be a [String], an [InternetAddress] or a [List] of
+   * [InternetAddress]es. If [host] is a
+   * [String], [connect] will perform a [InternetAddress.lookup] and try
+   * all returned [InternetAddress]es, in turn, until connected. If a connection
+   * was not possibly to any of the [InternetAddress]es, the error from the last

[Ivan Posva, 2014/04/30 16:28:06]

ditto

[Anders Johnsen, 2014/05/01 06:31:23]

Done.

+   * attempt is returned.
    */
   external static Future<Socket> connect(host, int port);
 
   /**
    * Destroy the socket in both directions. Calling [destroy] will make the
    * send a close event on the stream and will no longer react on data being
    * piped to it.
    *
    * Call [close](inherited from [IOSink]) to only close the [Socket]
    * for sending data.
@@ skipping 181 matching lines @@
     }
     if (address != null) {
       sb.write(", address = ${address.host}");
     }
     if (port != null) {
       sb.write(", port = $port");
     }
     return sb.toString();
   }
 }