Make Socket::connect try all addresses given.

runtime/bin/socket_patch.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class RawServerSocket {
   /* patch */ static Future<RawServerSocket> bind(address,
                                                   int port,
                                                   {int backlog: 0,
                                                    bool v6Only: false}) {
     return _RawServerSocket.bind(address, port, backlog, v6Only);
@@ skipping 463 matching lines @@
                   return map;
                 });
             return map.values.toList();
           }
         });
   }
 
   static Future<_NativeSocket> connect(host, int port) {
     return new Future.value(host)
         .then((host) {
-          if (host is _InternetAddress) return host;
+          if (host is _InternetAddress) return [host];
+          if (host is List) {

[Søren Gjesse, 2014/04/30 13:11:56]

We don't want to support a List here.

[Anders Johnsen, 2014/05/01 06:31:23]

Done.

+            for (var entry in host) {
+              if (entry is! _InternetAddress) {
+                throw new ArgumentError(
+                    "When passing a List as `host`, the entries"
+                    " must be InternetAddresses");
+              }
+            }
+            return host;
+          }
           return lookup(host)
               .then((list) {
                 if (list.length == 0) {
                   throw createError(response, "Failed host lookup: '$host'");
                 }
-                return list[0];
+                return list;
               });
         })
-        .then((address) {
-          var socket = new _NativeSocket.normal();
-          socket.address = address;
-          var result = socket.nativeCreateConnect(
-              address._in_addr, port);
-          if (result is OSError) {
-            throw createError(result, "Connection failed", address, port);
-          } else {
-            socket.port;  // Query the local port, for error messages.
-            var completer = new Completer();
-            // Setup handlers for receiving the first write event which
-            // indicate that the socket is fully connected.
-            socket.setHandlers(
-                write: () {
-                  socket.setListening(read: false, write: false);
-                  completer.complete(socket);
-                },
-                error: (e) {
-                  socket.close();
-                  completer.completeError(e);
-                }
-            );
-            socket.setListening(read: false, write: true);
-            return completer.future;
+        .then((addresses) {
+          assert(addresses is List);
+          var completer = new Completer();
+          var it = addresses.iterator;
+          void run(error) {
+            if (!it.moveNext()) {
+              assert(error != null);
+              completer.completeError(error);

[Søren Gjesse, 2014/04/30 13:11:56]

This will just return the error from the last one which failed, but I guess
there is nothing better we can do.

[Ivan Posva, 2014/04/30 16:28:06]

You could collect them all in a List and have a multi error object that you set
in this case.

[Anders Johnsen, 2014/05/01 06:31:23]

It's just hard to fit in our current model, without breaking it. Thinking about
it, we should actually return the first error. That's the one you would 'expect'
to get.

+              return;
+            }
+            var address = it.current;
+            var socket = new _NativeSocket.normal();
+            socket.address = address;
+            var result = socket.nativeCreateConnect(address._in_addr, port);
+            if (result is OSError) {
+              run(createError(result, "Connection failed", address, port));
+            } else {
+              socket.port;  // Query the local port, for error messages.
+              // Setup handlers for receiving the first write event which
+              // indicate that the socket is fully connected.
+              socket.setHandlers(
+                  write: () {
+                    socket.setListening(read: false, write: false);
+                    completer.complete(socket);
+                  },
+                  error: (e) {
+                    socket.close();
+                    run(e);
+                  }
+              );
+              socket.setListening(read: false, write: true);
+            }
           }
+          run(null);
+          return completer.future;
         });
   }
 
   static Future<_NativeSocket> bind(host,
                                     int port,
                                     int backlog,
                                     bool v6Only) {
     return new Future.value(host)
         .then((host) {
           if (host is _InternetAddress) return host;
@@ skipping 1252 matching lines @@
                        String address,
                        List<int> in_addr,
                        int port) {
   return new Datagram(
       data,
       new _InternetAddress(address, null, in_addr),
       port);
 }
 
 String _socketsStats() => _SocketsObservatory.toJSON();