Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: content/renderer/dom_storage/local_storage_cached_area.h

Issue 2593503005: Don't abuse LevelDBObserver interface to pass GetAll result. (Closed)
Patch Set: modify sanity_check test to give async callbacks a chance to cause problems Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/dom_storage/local_storage_cached_area.h
diff --git a/content/renderer/dom_storage/local_storage_cached_area.h b/content/renderer/dom_storage/local_storage_cached_area.h
index 11915a9b9b983aa2e784154abc87a6e5f48c5349..e2902af83a113125e6f50addfc4b975337382810 100644
--- a/content/renderer/dom_storage/local_storage_cached_area.h
+++ b/content/renderer/dom_storage/local_storage_cached_area.h
@@ -76,7 +76,6 @@ class LocalStorageCachedArea : public mojom::LevelDBObserver,
const std::vector<uint8_t>& old_value,
const std::string& source) override;
void AllDeleted(const std::string& source) override;
- void GetAllComplete(const std::string& source) override;
// Common helper for KeyAdded() and KeyChanged()
void KeyAddedOrChanged(const std::vector<uint8_t>& key,
@@ -91,6 +90,7 @@ class LocalStorageCachedArea : public mojom::LevelDBObserver,
void OnSetItemComplete(const base::string16& key, bool success);
void OnRemoveItemComplete(const base::string16& key, bool success);
void OnClearComplete(bool success);
+ void OnGetAllComplete(bool success);
// Resets the object back to its newly constructed state.
void Reset();
@@ -99,7 +99,6 @@ class LocalStorageCachedArea : public mojom::LevelDBObserver,
scoped_refptr<DOMStorageMap> map_;
std::map<base::string16, int> ignore_key_mutations_;
bool ignore_all_mutations_ = false;
- std::string get_all_request_id_;
mojom::LevelDBWrapperPtr leveldb_;
mojo::AssociatedBinding<mojom::LevelDBObserver> binding_;
LocalStorageCachedAreas* cached_areas_;

Powered by Google App Engine
This is Rietveld 408576698