content/browser/leveldb_wrapper_impl.h - Issue 2593503005: Don't abuse LevelDBObserver interface to pass GetAll result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/leveldb_wrapper_impl.h

Issue 2593503005: Don't abuse LevelDBObserver interface to pass GetAll result. (Closed)

Patch Set: modify sanity_check test to give async callbacks a chance to cause problems Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/leveldb_wrapper_impl.h

diff --git a/content/browser/leveldb_wrapper_impl.h b/content/browser/leveldb_wrapper_impl.h

index 663d5d85c7fab7bd4149cc2e90bcd83fb18da994..2ccf642598cf2ede4d7e03d16fa2b75d71dfc525 100644

--- a/content/browser/leveldb_wrapper_impl.h

+++ b/content/browser/leveldb_wrapper_impl.h

@@ -103,8 +103,9 @@ class CONTENT_EXPORT LevelDBWrapperImpl : public mojom::LevelDBWrapper {

const DeleteAllCallback& callback) override;

void Get(const std::vector<uint8_t>& key,

const GetCallback& callback) override;

- void GetAll(const std::string& source,

- const GetAllCallback& callback) override;

+ void GetAll(

+ mojom::LevelDBWrapperGetAllCallbackAssociatedPtrInfo complete_callback,

+ const GetAllCallback& callback) override;

void OnConnectionError();

void LoadMap(const base::Closure& completion_callback);