[MD settings] remove action menu from all-sites

chrome/test/data/webui/settings/site_list_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-list. */
 cr.define('site_list', function() {
   function registerTests() {
     suite('SiteList', function() {
       /**
        * A site list element created before each test.
@@ skipping 691 matching lines @@
         setUpCategory(settings.ContentSettingsTypes.GEOLOCATION,
             settings.PermissionValues.ALLOW, prefsOneDisabled);
         return browserProxy.whenCalled('getExceptionList').then(
             function(contentType) {
               assertEquals(
                   settings.ContentSettingsTypes.GEOLOCATION, contentType);
               assertFalse(testElement.$.category.hidden);
             });
       });
 
+      test('All sites category no action menu', function() {
+        setUpCategory(settings.ALL_SITES, '', prefsVarious);
+        return browserProxy.whenCalled('getExceptionList').then(
+            function(contentType) {
+              // Use resolver to ensure asserts bubble up to the framework with
+              // meaningful errors.
+              var resolver = new PromiseResolver();
+              testElement.async(resolver.resolve);
+              return resolver.promise.then(function() {

[dschuyler, 2016/12/21 02:06:47]

I'm including this promise resolve because other tests in this file do so and it
seems to help. I'm not 100% clear on why though. Are you more familiar with the
issue here?

[dpapad, 2016/12/21 02:32:13]

The comment is a bit misleading (or I am misunderstanding). I thought the
Resolver is only used to artificially yield to the message loop so that the
dom-repeat renders. Errors are reported correctly anyway, no?

Another way I was able to make it work was http://imgur.com/a/rsxHj.

Summarizing our discussion, listening for the dom-change event fired from the
dom-repeat seems promising, but might be more involved than this UI deserves.

[dschuyler, 2016/12/21 02:39:39]

Thanks for looking at that with me. Knowing when Polymer is finished startup is
a long standing issue. I like your ideas on finding better ways to do it, and I
agree that it's more than needed for this particular CL.

Changed comment.

+                var item = testElement.$.listContainer.children[0];
+                var dots = item.querySelector('paper-icon-button');
+                assertTrue(!!dots);
+                assertTrue(dots.hidden);
+              });
+            });
+      });
+
       test('All sites category', function() {
         // Prefs: Multiple and overlapping sites.
         setUpCategory(settings.ALL_SITES, '', prefsVarious);
 
         return browserProxy.whenCalled('getExceptionList').then(
             function(contentType) {
               // Use resolver to ensure asserts bubble up to the framework with
               // meaningful errors.
               var resolver = new PromiseResolver();
               testElement.async(resolver.resolve);
@@ skipping 129 matching lines @@
           assertEquals(settings.ContentSettingsTypes.JAVASCRIPT, args[2]);
           assertEquals('allow', args[3]);
         });
       });
     });
   }
   return {
     registerTests: registerTests,
   };
 });