Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/android/search_geolocation_disclosure_tab_helper.h

Issue 2593393002: Add some integration tests for the search geolocation disclosure. (Closed)
Patch Set: Nits and a comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/search_geolocation_disclosure_tab_helper.h
diff --git a/chrome/browser/android/search_geolocation_disclosure_tab_helper.h b/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
index 00ed39c0722171896bb475164c4b3221098818d9..1eac8be4895635e877977f38cfff86342ca5df2c 100644
--- a/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
+++ b/chrome/browser/android/search_geolocation_disclosure_tab_helper.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_
#define CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_DISCLOSURE_TAB_HELPER_H_
+#include <jni.h>
+
#include "base/macros.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
@@ -30,6 +32,9 @@ class SearchGeolocationDisclosureTabHelper
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+ // Registers native methods.
+ static bool Register(JNIEnv* env);
+
private:
explicit SearchGeolocationDisclosureTabHelper(content::WebContents* contents);
friend class content::WebContentsUserData<
@@ -37,6 +42,8 @@ class SearchGeolocationDisclosureTabHelper
void MaybeShowDefaultSearchGeolocationDisclosure(const GURL& gurl);
+ bool ShouldShowDisclosureForUrl(const GURL& gurl);
+
// Record metrics, once per client, of the permission state before and after
// the disclosure has been shown.
void RecordPreDisclosureMetrics(const GURL& gurl);
« no previous file with comments | « chrome/browser/android/chrome_jni_registrar.cc ('k') | chrome/browser/android/search_geolocation_disclosure_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698