Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: appengine/findit/crash/chromecrash_parser.py

Issue 2593383002: [Predator] Move ``FilterStackBuffer`` from stack parser to ``AddFilteredStack`` of stacktrace buffe… (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/callstack_filters.py ('k') | appengine/findit/crash/stacktrace.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/chromecrash_parser.py
diff --git a/appengine/findit/crash/chromecrash_parser.py b/appengine/findit/crash/chromecrash_parser.py
index 2928500b08a7fbdd761e79dda5b81a08592dd431..2d3db876f688e40e2c58a565f24ff7e088f811e8 100644
--- a/appengine/findit/crash/chromecrash_parser.py
+++ b/appengine/findit/crash/chromecrash_parser.py
@@ -23,11 +23,11 @@ class ChromeCrashParser(StacktraceParser):
def Parse(self, stacktrace_string, deps, signature=None, top_n_frames=None):
"""Parse fracas stacktrace string into Stacktrace instance."""
- stacktrace_buffer = StacktraceBuffer(signature=signature)
# Filters to filter callstack buffers.
filters = [callstack_filters.FilterInlineFunction(),
callstack_filters.KeepTopNFrames(top_n_frames or
DEFAULT_TOP_N_FRAMES)]
+ stacktrace_buffer = StacktraceBuffer(signature=signature, filters=filters)
# Initial background callstack which is not to be added into Stacktrace.
stack_buffer = CallStackBuffer()
@@ -36,12 +36,7 @@ class ChromeCrashParser(StacktraceParser):
self._IsStartOfNewCallStack(line))
if is_new_callstack:
- # TODO(katesonia): Refactor this logic to ``AddFilteredStack`` method
- # of StacktraceBuffer.
- stack_buffer = StacktraceParser.FilterStackBuffer(stack_buffer, filters)
- if stack_buffer:
- stacktrace_buffer.stacks.append(stack_buffer)
-
+ stacktrace_buffer.AddFilteredStack(stack_buffer)
stack_buffer = CallStackBuffer(priority=priority,
format_type=format_type,
language_type=language_type)
@@ -52,9 +47,8 @@ class ChromeCrashParser(StacktraceParser):
if frame is not None:
stack_buffer.frames.append(frame)
- stack_buffer = StacktraceParser.FilterStackBuffer(stack_buffer, filters)
- if stack_buffer:
- stacktrace_buffer.stacks.append(stack_buffer)
+ # Add the last stack to stacktrace.
+ stacktrace_buffer.AddFilteredStack(stack_buffer)
return stacktrace_buffer.ToStacktrace()
« no previous file with comments | « appengine/findit/crash/callstack_filters.py ('k') | appengine/findit/crash/stacktrace.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698