Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: appengine/findit/crash/test/stacktrace_parser_test.py

Issue 2593383002: [Predator] Move ``FilterStackBuffer`` from stack parser to ``AddFilteredStack`` of stacktrace buffe… (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/stacktrace_parser_test.py
diff --git a/appengine/findit/crash/test/stacktrace_parser_test.py b/appengine/findit/crash/test/stacktrace_parser_test.py
deleted file mode 100644
index 26830460c91733b32d38b59bfe062d78f20c06d4..0000000000000000000000000000000000000000
--- a/appengine/findit/crash/test/stacktrace_parser_test.py
+++ /dev/null
@@ -1,60 +0,0 @@
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from crash import callstack_filters
-from crash.stacktrace import CallStackBuffer
-from crash.stacktrace import StackFrame
-from crash.stacktrace_parser import StacktraceParser
-from crash.test.stacktrace_test_suite import StacktraceTestSuite
-
-
-class DummyFilter(callstack_filters.CallStackFilter):
-
- def __call__(self, stack_buffer): # pragma: no cover
- return stack_buffer
-
-
-class StacktraceParserTest(StacktraceTestSuite):
-
- def testFilterInfinityPriorityStackBuffer(self):
- """Tests ``FilterStackBuffer`` return None for inf priority stack buffer."""
- stack_buffer = CallStackBuffer(priority=float('inf'))
- self.assertIsNone(StacktraceParser.FilterStackBuffer(stack_buffer,
- [DummyFilter()]))
-
- def testFilterEmptyStackBuffer(self):
- """Tests ``FilterStackBuffer`` return None for empty stack buffer."""
- stack_buffer = CallStackBuffer(frame_list=[])
- self.assertIsNone(StacktraceParser.FilterStackBuffer(stack_buffer,
- [DummyFilter()]))
-
- def testFilterAllFrames(self):
- """Tests ``FilterStackBuffer`` filters all frames and resturn None."""
- frame_list = [
- StackFrame(0, 'src/', 'func', 'file0.cc', 'src/file0.cc', [32]),
- StackFrame(0, 'src/', 'func2', 'file0.cc', 'src/file0.cc', [32])]
- stack_buffer = CallStackBuffer(0, frame_list=frame_list)
-
- def _MockFilter(stack_buffer):
- stack_buffer.frames = None
- return stack_buffer
-
- self.assertIsNone(StacktraceParser.FilterStackBuffer(
- stack_buffer,
- filters=[_MockFilter]))
-
- def testFilterSomeFrames(self):
- """Tests ``FilterStackBuffer`` filters some frames."""
- frame_list = [
- StackFrame(0, 'src/', 'func', 'file0.cc', 'src/file0.cc', [32]),
- StackFrame(0, 'src/', 'func2', 'file0.cc', 'src/file0.cc', [32])]
- stack_buffer = CallStackBuffer(0, frame_list=frame_list)
-
- def _MockFilter(stack):
- stack.frames = stack.frames[:1]
- return stack
-
- self._VerifyTwoCallStacksEqual(
- StacktraceParser.FilterStackBuffer(stack_buffer, filters=[_MockFilter]),
- CallStackBuffer(stack_buffer.priority, frame_list=frame_list[:1]))

Powered by Google App Engine
This is Rietveld 408576698