Use the physical-pixel space for native IME on linux platform.

ui/base/ime/input_method_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/ime/input_method_win.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <cwctype>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "ui/base/ime/ime_bridge.h"
 #include "ui/base/ime/ime_engine_handler_interface.h"
 #include "ui/base/ime/text_input_client.h"
 #include "ui/base/ime/win/tsf_input_scope.h"
 #include "ui/base/ui_base_switches.h"
-#include "ui/display/win/screen_win.h"
 #include "ui/events/event.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/keycodes/keyboard_codes.h"
+#include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/win/hwnd_util.h"
 
 namespace {
 
 ui::IMEEngineHandlerInterface* GetEngine() {
   if (ui::IMEBridge::Get())
     return ui::IMEBridge::Get()->GetCurrentEngineHandler();
   return nullptr;
 }
 
@@ skipping 192 matching lines @@
       text_input_type != TEXT_INPUT_TYPE_PASSWORD && GetEngine()) {
     // |enabled_| == false could be faked, and the engine should rely on the
     // real type from GetTextInputType().
     GetEngine()->SetCompositionBounds(GetCompositionBounds(client));
   }
   if (!enabled_)
     return;
 
   // The current text input type should not be NONE if |client| is focused.
   DCHECK(!IsTextInputTypeNone());
-  // Tentatively assume that the returned value is DIP (Density Independent
-  // Pixel). See the comment in text_input_client.h and http://crbug.com/360334.
+  // Windows IME uses the non-dip coordinates.
+  // See the comment in text_input_client.h and http://crbug.com/360334.
   const gfx::Rect dip_screen_bounds(GetTextInputClient()->GetCaretBounds());
   const gfx::Rect screen_bounds =
-      display::win::ScreenWin::DIPToScreenRect(toplevel_window_handle_,

[sadrul, 2016/12/22 01:30:22]

Does the old code not do the right thing, because it looks like that too tries
to convert from DIP to pixel-space?

[Shu Chen, 2016/12/22 03:02:27]

The old code does the right thing but I think it would be better to use the
consistent way to do the coordinates transform cross platforms (win/linux).

 

-                                               dip_screen_bounds);
+      gfx::ScaleToEnclosingRect(
+          dip_screen_bounds, GetTextInputClient()->GetScaleFactor());
 
   HWND attached_window = toplevel_window_handle_;
   // TODO(ime): see comment in TextInputClient::GetCaretBounds(), this
   // conversion shouldn't be necessary.
   RECT r = {};
   GetClientRect(attached_window, &r);
   POINT window_point = { screen_bounds.x(), screen_bounds.y() };
   ScreenToClient(attached_window, &window_point);
   gfx::Rect caret_rect(gfx::Point(window_point.x, window_point.y),
                        screen_bounds.size());
@@ skipping 371 matching lines @@
   if (!char_positon)
     return 0;
 
   if (char_positon->dwSize < sizeof(IMECHARPOSITION))
     return 0;
 
   ui::TextInputClient* client = GetTextInputClient();
   if (!client)
     return 0;
 
-  // Tentatively assume that the returned value from |client| is DIP (Density
-  // Independent Pixel). See the comment in text_input_client.h and
-  // http://crbug.com/360334.
   gfx::Rect dip_rect;
   if (client->HasCompositionText()) {
     if (!client->GetCompositionCharacterBounds(char_positon->dwCharPos,
                                                &dip_rect)) {
       return 0;
     }
   } else {
     // If there is no composition and the first character is queried, returns
     // the caret bounds. This behavior is the same to that of RichEdit control.
     if (char_positon->dwCharPos != 0)
       return 0;
     dip_rect = client->GetCaretBounds();
   }
+  // Windows IME uses the non-dip coordinates.
+  // See the comment in text_input_client.h and http://crbug.com/360334.
   const gfx::Rect rect =
-      display::win::ScreenWin::DIPToScreenRect(toplevel_window_handle_,
-                                               dip_rect);
+      gfx::ScaleToEnclosingRect(dip_rect, client->GetScaleFactor());

[sadrul, 2016/12/22 01:30:22]

Can you use ConvertRectToDIP/ConvertRectToPixel instead?

https://cs.chromium.org/chromium/src/ui/compositor/dip_util.h?q=ConvertRectTo...

[Shu Chen, 2016/12/22 03:02:27]

I don't think so, because that would require a Layer instance which doesn't
available in ui/base/ime space.

 
   char_positon->pt.x = rect.x();
   char_positon->pt.y = rect.y();
   char_positon->cLineHeight = rect.height();
   return 1;  // returns non-zero value when succeeded.
 }
 
 bool InputMethodWin::IsWindowFocused(const TextInputClient* client) const {
   if (!client)
     return false;
@@ skipping 71 matching lines @@
   ui::IMEEngineHandlerInterface* engine = GetEngine();
   if (engine) {
     if (old_text_input_type != ui::TEXT_INPUT_TYPE_NONE)
       engine->FocusOut();
     if (GetTextInputType() != ui::TEXT_INPUT_TYPE_NONE)
       engine->FocusIn(context);
   }
 }
 
 }  // namespace ui