Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2593273003: DevTools: Do not reset timeline recoring options on basic/advanced switch. (Closed)
Patch Set: more tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @implements {SDK.TargetManager.Observer} 6 * @implements {SDK.TargetManager.Observer}
7 * @implements {SDK.TracingManagerClient} 7 * @implements {SDK.TracingManagerClient}
8 * @unrestricted 8 * @unrestricted
9 */ 9 */
10 Timeline.TimelineController = class { 10 Timeline.TimelineController = class {
11 /** 11 /**
12 * @param {!SDK.Target} target 12 * @param {!SDK.Target} target
13 * @param {!Timeline.TimelineLifecycleDelegate} delegate 13 * @param {!Timeline.TimelineLifecycleDelegate} delegate
14 * @param {!SDK.TracingModel} tracingModel 14 * @param {!SDK.TracingModel} tracingModel
15 */ 15 */
16 constructor(target, delegate, tracingModel) { 16 constructor(target, delegate, tracingModel) {
17 this._delegate = delegate; 17 this._delegate = delegate;
18 this._target = target; 18 this._target = target;
19 this._tracingModel = tracingModel; 19 this._tracingModel = tracingModel;
20 this._targets = []; 20 this._targets = [];
21 /** @type {!Array<!Timeline.ExtensionTracingSession>} */ 21 /** @type {!Array<!Timeline.ExtensionTracingSession>} */
22 this._extensionSessions = []; 22 this._extensionSessions = [];
23 SDK.targetManager.observeTargets(this); 23 SDK.targetManager.observeTargets(this);
24 } 24 }
25 25
26 /** 26 /**
27 * @param {!Timeline.TimelineController.CaptureOptions} options 27 * @param {!Timeline.TimelineController.RecordingOptions} options
28 * @param {!Array<!Extensions.ExtensionTraceProvider>} providers 28 * @param {!Array<!Extensions.ExtensionTraceProvider>} providers
29 */ 29 */
30 startRecording(options, providers) { 30 startRecording(options, providers) {
31 this._extensionTraceProviders = Extensions.extensionServer.traceProviders(). slice(); 31 this._extensionTraceProviders = Extensions.extensionServer.traceProviders(). slice();
32 32
33 /** 33 /**
34 * @param {string} category 34 * @param {string} category
35 * @return {string} 35 * @return {string}
36 */ 36 */
37 function disabledByDefault(category) { 37 function disabledByDefault(category) {
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 271
272 /** 272 /**
273 * @param {number} progress 273 * @param {number} progress
274 * @override 274 * @override
275 */ 275 */
276 eventsRetrievalProgress(progress) { 276 eventsRetrievalProgress(progress) {
277 this._delegate.loadingProgress(progress); 277 this._delegate.loadingProgress(progress);
278 } 278 }
279 }; 279 };
280 280
281 /** @typedef {!{ 281 /**
282 * enableJSSampling: (boolean|undefined), 282 * @typedef {!{
283 * capturePictures: (boolean|undefined), 283 * enableJSSampling: (boolean|undefined),
284 * captureFilmStrip: (boolean|undefined) 284 * capturePictures: (boolean|undefined),
285 * }} 285 * captureFilmStrip: (boolean|undefined)
286 * }}
286 */ 287 */
287 Timeline.TimelineController.CaptureOptions; 288 Timeline.TimelineController.RecordingOptions;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698