content/test/data/accessibility/html/a-no-text.html - Issue 2593263003: Use a non-replaced inline container for image alt text

Unified Diff: content/test/data/accessibility/html/a-no-text.html

Issue 2593263003: Use a non-replaced inline container for image alt text (Closed)

Patch Set: Use a non-replaced inline container for image alt text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/test/data/android/contextmenu/context_menu_test.html ('k') | third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level2/html/HTMLImageElement05-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/data/accessibility/html/a-no-text.html

diff --git a/content/test/data/accessibility/html/a-no-text.html b/content/test/data/accessibility/html/a-no-text.html

index 971a413315cd133ebdba17733db6b3bb62181d05..8310d5e965dc26da74b1ca6de21115fc3480d011 100644

--- a/content/test/data/accessibility/html/a-no-text.html

+++ b/content/test/data/accessibility/html/a-no-text.html

@@ -3,14 +3,14 @@

-->

<html>

rhogan 2017/04/17 09:49:47 dmazzoni, need your input here. The changes I'm m

dmazzoni, need your input here. The changes I'm making to the way we display fallback content affects some assumptions in this test about the accessibility tree. I believe this is because I am changing the shadow root used to display fallback content from something like: <div id="alttext-container" style="overflow: hidden; border-width: 1px; border-style: solid; border-color: silver; display: inline-block; box-sizing: border-box; padding: 1px;"><img id="alttext-image" width="16" height="16" align="left" style="margin: 0px; float: left; display: none;"><div id="alttext" style="overflow: hidden; display: block;"></div></div> to: <span id="alttext-container"><img id="alttext-image" width="16" height="16" align="left" style="margin: 0px; display: none;"><span id="alttext"></span></span> I'm guessing that the accessibilty tree has different expectations of what to pull from inline versus block elements maybe? So my question is: what would you like me to do here? Just rebaseline the test? Or change it in a way similar to the way I've changed it here? Here is the accessibility tree for this test before and after my CL: Before: AXTreeUpdate tree data: doctype=html loaded=true loading_progress=1 mimetype=text/html url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html focus_id=4 routing_id=2 AXTreeUpdate: clear node 1 AXTreeUpdate: root id 4 id=4 rootWebArea FOCUSABLE READONLY (0, 0)-(800, 600) background_color=&FFFFFFFF color=&FF000000 scroll_x=0 scroll_y=0 scroll_x_min=0 scroll_y_min=0 scroll_x_max=0 scroll_y_max=0 value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html font-family=Times New Roman html_tag=#document font_size=16 child_ids=6 id=6 group READONLY (8, 8)-(784, 584) offset_container_id=4 background_color=&FFFFFFFF color=&FF000000 value= display=block html_tag=body font_size=16 child_ids=7,9,11,13,15,17,19,21,23,26 id=7 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest1 display=inline html_tag=a font_size=16 id=9 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///dest2 display=inline html_tag=a font_size=16 id=11 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest3/ display=inline html_tag=a font_size=16 id=13 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=http://example.com/dest4 display=inline html_tag=a font_size=16 id=15 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=http://example.com/dest5/ display=inline html_tag=a font_size=16 id=17 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest6.html display=inline html_tag=a font_size=16 id=19 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=http://example.com/dest7.html display=inline html_tag=a font_size=16 id=21 link FOCUSABLE LINKED OFFSCREEN READONLY (8, 8)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=http://example.com/dest.8.html display=inline html_tag=a font_size=16 id=23 link FOCUSABLE LINKED READONLY (8, 8)-(200, 103) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest9.html display=inline html_tag=a font_size=16 child_ids=36 id=36 image LINKED READONLY (8, 8)-(200, 100) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/greenbox.png display=inline html_tag=img role=img font_size=16 id=26 link FOCUSABLE LINKED READONLY (212, 8)-(200, 103) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest10.html display=inline html_tag=a font_size=16 child_ids=37 id=37 image LINKED READONLY (212, 8)-(200, 100) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/greenbox.png display=inline html_tag=img role=img font_size=16 [1:1:0417/101707.388342:228573758262:VERBOSE1:render_accessibility_impl.cc(416)] Accessibility event: loadComplete on node id 4 After: AXTreeUpdate tree data: doctype=html loaded=true loading_progress=1 mimetype=text/html url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html focus_id=4 routing_id=2 AXTreeUpdate: clear node 1 AXTreeUpdate: root id 4 id=4 rootWebArea FOCUSABLE READONLY (0, 0)-(800, 600) background_color=&FFFFFFFF color=&FF000000 scroll_x=0 scroll_y=0 scroll_x_min=0 scroll_y_min=0 scroll_x_max=0 scroll_y_max=0 value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html font-family=Times New Roman html_tag=#document font_size=16 child_ids=6 id=6 group READONLY (8, 8)-(784, 584) offset_container_id=4 background_color=&FFFFFFFF color=&FF000000 value= display=block html_tag=body font_size=16 child_ids=7,9,11,13,15,17,19,21,23,26 id=7 link FOCUSABLE LINKED READONLY (8, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest1 display=inline html_tag=a font_size=16 child_ids=28 id=28 image LINKED OFFSCREEN READONLY (8, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=9 link FOCUSABLE LINKED READONLY (12, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=file:///dest2 display=inline html_tag=a font_size=16 child_ids=31 id=31 image LINKED OFFSCREEN READONLY (12, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=11 link FOCUSABLE LINKED READONLY (16, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest3/ display=inline html_tag=a font_size=16 child_ids=34 id=34 image LINKED OFFSCREEN READONLY (16, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=13 link FOCUSABLE LINKED READONLY (20, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=http://example.com/dest4 display=inline html_tag=a font_size=16 child_ids=37 id=37 image LINKED OFFSCREEN READONLY (20, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=15 link FOCUSABLE LINKED READONLY (24, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=http://example.com/dest5/ display=inline html_tag=a font_size=16 child_ids=40 id=40 image LINKED OFFSCREEN READONLY (24, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=17 link FOCUSABLE LINKED READONLY (28, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest6.html display=inline html_tag=a font_size=16 child_ids=43 id=43 image LINKED OFFSCREEN READONLY (28, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=19 link FOCUSABLE LINKED READONLY (32, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=http://example.com/dest7.html display=inline html_tag=a font_size=16 child_ids=46 id=46 image LINKED OFFSCREEN READONLY (32, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=21 link FOCUSABLE LINKED READONLY (36, 94)-(4, 17) offset_container_id=4 name_from=contents background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump name= value= url=http://example.com/dest.8.html display=inline html_tag=a font_size=16 child_ids=49 id=49 image LINKED OFFSCREEN READONLY (36, 108)-(0, 0) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/a-no-text.html display=inline html_tag=img role=img font_size=16 id=23 link FOCUSABLE LINKED READONLY (40, 8)-(200, 103) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest9.html display=inline html_tag=a font_size=16 child_ids=52 id=52 image LINKED READONLY (40, 8)-(200, 100) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/greenbox.png display=inline html_tag=img role=img font_size=16 id=26 link FOCUSABLE LINKED READONLY (244, 8)-(200, 103) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE text_style=underline action=jump value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/dest10.html display=inline html_tag=a font_size=16 child_ids=53 id=53 image LINKED READONLY (244, 8)-(200, 100) offset_container_id=4 background_color=&FFFFFFFF color=&FF0000EE action=click value= url=file:///home/robert/Dev/blink/src/content/test/data/accessibility/html/greenbox.png display=inline html_tag=img role=img font_size=16

<body>

- <a href="dest1"><img src=""> </a>

- <a href="/dest2"><img src=""> </a>

- <a href="dest3/"><img src=""> </a>

- <a href="http://example.com/dest4"><img src=""> </a>

- <a href="http://example.com/dest5/"><img src=""> </a>

- <a href="dest6.html"><img src=""> </a>

- <a href="http://example.com/dest7.html"><img src=""> </a>

- <a href="http://example.com/dest.8.html"><img src=""> </a>

+ <a href="dest1"><img src="" alt="text"> </a>

+ <a href="/dest2"><img src="" alt="text"> </a>

+ <a href="dest3/"><img src="" alt="text"> </a>

+ <a href="http://example.com/dest4"><img src="" alt="text"> </a>

+ <a href="http://example.com/dest5/"><img src="" alt="text"> </a>

+ <a href="dest6.html"><img src="" alt="text"> </a>

+ <a href="http://example.com/dest7.html"><img src="" alt="text"> </a>

+ <a href="http://example.com/dest.8.html"><img src="" alt="text"> </a>

</body>