Add network quality change events to net log

net/nqe/network_quality_estimator_unittest.cc

Index: net/nqe/network_quality_estimator_unittest.cc
diff --git a/net/nqe/network_quality_estimator_unittest.cc b/net/nqe/network_quality_estimator_unittest.cc
index 768a4152e35708e75b1312c156c39096bbb69271..e7b90d03003d3ad287ea1a9d335baaaa9e1e13ef 100644
--- a/net/nqe/network_quality_estimator_unittest.cc
+++ b/net/nqe/network_quality_estimator_unittest.cc
@@ -16,6 +16,7 @@
 
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
@@ -29,6 +30,7 @@
 #include "net/http/http_response_headers.h"
 #include "net/http/http_response_info.h"
 #include "net/http/http_status_code.h"
+#include "net/log/test_net_log.h"
 #include "net/nqe/effective_connection_type.h"
 #include "net/nqe/external_estimate_provider.h"
 #include "net/nqe/network_quality_estimator_test_util.h"
@@ -296,6 +298,9 @@ TEST(NetworkQualityEstimatorTest, TestKbpsRTTUpdates) {
                                      3);
   histogram_tester.ExpectBucketCount("NQE.CachedNetworkQualityAvailable", true,
                                      1);
+
+  EXPECT_LT(
+      0, estimator.GetEntriesCount(NetLogEventType::NETWORK_QUALITY_CHANGED));
 }
 
 // Tests that the network quality estimator writes and reads network quality
@@ -474,7 +479,8 @@ TEST(NetworkQualityEstimatorTest, DefaultObservations) {
   std::map<std::string, std::string> variation_params;
   TestNetworkQualityEstimator estimator(
       nullptr, variation_params, false, false,
-      true /* add_default_platform_observations */);
+      true /* add_default_platform_observations */,
+      base::MakeUnique<BoundTestNetLog>());
   base::TimeDelta rtt;
   int32_t kbps;
 
@@ -514,6 +520,8 @@ TEST(NetworkQualityEstimatorTest, DefaultObservations) {
   EXPECT_NE(
       EFFECTIVE_CONNECTION_TYPE_UNKNOWN,
       effective_connection_type_observer.effective_connection_types().front());
+  EXPECT_LT(
+      0, estimator.GetEntriesCount(NetLogEventType::NETWORK_QUALITY_CHANGED));

[eroman, 2017/01/19 23:57:25]

Is it not possible to expect an exact number of events?

[tbansal1, 2017/01/20 01:30:34]

Done.

 
   EXPECT_EQ(3, rtt_throughput_estimates_observer.notifications_received());
   EXPECT_EQ(base::TimeDelta::FromMilliseconds(272),
@@ -558,7 +566,8 @@ TEST(NetworkQualityEstimatorTest, DefaultObservationsOverridden) {
 
   TestNetworkQualityEstimator estimator(
       nullptr, variation_params, false, false,
-      true /* add_default_platform_observations */);
+      true /* add_default_platform_observations */,
+      base::MakeUnique<BoundTestNetLog>());
 
   base::TimeDelta rtt;
   int32_t kbps;
@@ -1451,7 +1460,8 @@ TEST(NetworkQualityEstimatorTest, TestThroughputNoRequestOverlap) {
     TestNetworkQualityEstimator estimator(
         std::unique_ptr<net::ExternalEstimateProvider>(), variation_params,
         test.allow_small_localhost_requests,
-        test.allow_small_localhost_requests, false);
+        test.allow_small_localhost_requests, false,
+        base::MakeUnique<BoundTestNetLog>());
 
     base::TimeDelta rtt;
     EXPECT_FALSE(estimator.GetRecentHttpRTT(base::TimeTicks(), &rtt));
@@ -1519,6 +1529,8 @@ TEST(NetworkQualityEstimatorTest, MAYBE_TestEffectiveConnectionTypeObserver) {
   request->Start();
   base::RunLoop().Run();
   EXPECT_EQ(1U, observer.effective_connection_types().size());
+  EXPECT_LT(
+      0, estimator.GetEntriesCount(NetLogEventType::NETWORK_QUALITY_CHANGED));
   histogram_tester.ExpectUniqueSample("NQE.MainFrame.EffectiveConnectionType",
                                       EFFECTIVE_CONNECTION_TYPE_2G, 1);
   histogram_tester.ExpectUniqueSample(
@@ -2609,7 +2621,8 @@ TEST(NetworkQualityEstimatorTest, OnPrefsRead) {
   // at the time of startup can be studied in isolation.
   TestNetworkQualityEstimator estimator(
       std::unique_ptr<net::ExternalEstimateProvider>(), variation_params, true,
-      true, false /* use_default_platform_values */);
+      true, false /* use_default_platform_values */,
+      base::MakeUnique<BoundTestNetLog>());
 
   // Add observers.
   TestRTTObserver rtt_observer;