Add network quality change events to net log

chrome/browser/android/net/external_estimate_provider_android_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/net/external_estimate_provider_android.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/at_exit.h"
+#include "base/memory/ptr_util.h"

[RyanSturm, 2017/01/10 16:22:37]

Not seeing where ptr_util is used.

[tbansal1, 2017/01/10 18:27:52]

Done.

 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
 #include "content/public/test/test_browser_thread_bundle.h"
+#include "net/log/test_net_log.h"
 #include "net/nqe/network_quality_estimator.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // Tests if the |ExternalEstimateProviderAndroid| APIs return false without the
 // downstream implementation.
 TEST(ExternalEstimateProviderAndroidTest, BasicsTest) {
   base::ShadowingAtExitManager at_exit_manager;
   chrome::android::ExternalEstimateProviderAndroid external_estimate_provider;
 
   base::TimeDelta rtt;
   EXPECT_FALSE(external_estimate_provider.GetRTT(&rtt));
 
   int32_t kbps;
   EXPECT_FALSE(external_estimate_provider.GetDownstreamThroughputKbps(&kbps));
   EXPECT_FALSE(external_estimate_provider.GetUpstreamThroughputKbps(&kbps));
 
   base::TimeDelta time_since_last_update;
   EXPECT_FALSE(external_estimate_provider.GetTimeSinceLastUpdate(
       &time_since_last_update));
 }
 
 class TestNetworkQualityEstimator : public net::NetworkQualityEstimator {
  public:
   TestNetworkQualityEstimator(
       std::unique_ptr<chrome::android::ExternalEstimateProviderAndroid>
           external_estimate_provider,
-      const std::map<std::string, std::string>& variation_params)
+      const std::map<std::string, std::string>& variation_params,
+      net::NetLog* net_log)
       : NetworkQualityEstimator(std::move(external_estimate_provider),
-                                variation_params),
+                                variation_params,
+                                net_log),
         notified_(false) {}
 
   ~TestNetworkQualityEstimator() override {}
 
   void OnUpdatedEstimateAvailable(const base::TimeDelta& rtt,
                                   int32_t downstream_throughput_kbps,
                                   int32_t upstream_throughput_kbps) override {
     EXPECT_EQ(base::TimeDelta(), rtt);
     EXPECT_EQ(-1, downstream_throughput_kbps);
     EXPECT_EQ(-1, upstream_throughput_kbps);
@@ skipping 29 matching lines @@
   content::TestBrowserThreadBundle thread_bundle(
       content::TestBrowserThreadBundle::IO_MAINLOOP);
 
   base::ShadowingAtExitManager at_exit_manager;
   base::HistogramTester histogram_tester;
   std::unique_ptr<TestExternalEstimateProviderAndroid>
       external_estimate_provider;
   external_estimate_provider.reset(new TestExternalEstimateProviderAndroid());
 
   TestExternalEstimateProviderAndroid* ptr = external_estimate_provider.get();
+  net::TestNetLog net_log;
   std::map<std::string, std::string> variation_params;
   TestNetworkQualityEstimator network_quality_estimator(
-      std::move(external_estimate_provider), variation_params);
+      std::move(external_estimate_provider), variation_params, &net_log);
   ptr->NotifyUpdatedEstimateAvailable();
   EXPECT_TRUE(network_quality_estimator.notified());
 
   histogram_tester.ExpectTotalCount("NQE.ExternalEstimateProviderStatus", 2);
 
   // EXTERNAL_ESTIMATE_PROVIDER_STATUS_AVAILABLE
   histogram_tester.ExpectBucketCount("NQE.ExternalEstimateProviderStatus", 1,
                                      1);
 
   // EXTERNAL_ESTIMATE_PROVIDER_STATUS_CALLBACK
   histogram_tester.ExpectBucketCount("NQE.ExternalEstimateProviderStatus", 4,
                                      1);
 }
 
 }  // namespace