Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8262)

Unified Diff: chrome/browser/task_manager/task_manager_tester.cc

Issue 2593233003: Add a task manager column that shows memory state of processes (Closed)
Patch Set: fix compile error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/task_manager_tester.h ('k') | chrome/browser/task_manager/test_task_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/task_manager_tester.cc
diff --git a/chrome/browser/task_manager/task_manager_tester.cc b/chrome/browser/task_manager/task_manager_tester.cc
index 5d6bd43cf7066ff2dfa353be9e38ad3cb07ddd65..f93a2497d90e585aa4565270c6aae8e647a32051 100644
--- a/chrome/browser/task_manager/task_manager_tester.cc
+++ b/chrome/browser/task_manager/task_manager_tester.cc
@@ -109,6 +109,9 @@ void TaskManagerTester::ToggleColumnVisibility(ColumnSpecifier column) {
case ColumnSpecifier::IDLE_WAKEUPS:
column_id = IDS_TASK_MANAGER_IDLE_WAKEUPS_COLUMN;
break;
+ case ColumnSpecifier::MEMORY_STATE:
+ column_id = IDS_TASK_MANAGER_MEMORY_STATE_COLUMN;
+ break;
}
model_->ToggleColumnVisibility(column_id);
}
@@ -121,6 +124,7 @@ int64_t TaskManagerTester::GetColumnValue(ColumnSpecifier column, int row) {
switch (column) {
case ColumnSpecifier::COLUMN_NONE:
+ case ColumnSpecifier::MEMORY_STATE:
break;
case ColumnSpecifier::V8_MEMORY:
success = task_manager()->GetV8Memory(task_id, &value, &ignored);
@@ -147,6 +151,11 @@ int32_t TaskManagerTester::GetTabId(int row) {
return task_manager()->GetTabId(task_id);
}
+base::MemoryState TaskManagerTester::GetMemoryState(int row) {
+ TaskId task_id = model_->tasks_[row];
+ return task_manager()->GetMemoryState(task_id);
+}
+
void TaskManagerTester::Kill(int row) {
model_->KillTask(row);
}
« no previous file with comments | « chrome/browser/task_manager/task_manager_tester.h ('k') | chrome/browser/task_manager/test_task_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698