Add a task manager column that shows memory state of processes

chrome/browser/task_manager/task_manager_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/path_service.h"
@@ skipping 21 matching lines @@
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/infobars/core/infobar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/browser/render_frame_host.h"
+#include "content/public/common/content_features.h"
+#include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/extension.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/page_transition_types.h"
@@ skipping 117 matching lines @@
     command_line->AppendSwitch(switches::kV8PacMojoOutOfProcess);
     command_line->AppendSwitchASCII(
         switches::kProxyPacUrl,
         "data:,function FindProxyForURL(url, host){return \"DIRECT;\";}");
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TaskManagerUtilityProcessBrowserTest);
 };
 
+class TaskManagerMemoryCoordinatorBrowserTest : public TaskManagerBrowserTest {
+ public:
+  TaskManagerMemoryCoordinatorBrowserTest() {}
+  ~TaskManagerMemoryCoordinatorBrowserTest() override {}
+
+ protected:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitchASCII(switches::kEnableFeatures,
+                                    features::kMemoryCoordinator.name);
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TaskManagerMemoryCoordinatorBrowserTest);
+};
+
 // Parameterized variant of TaskManagerBrowserTest which runs with/without
 // --site-per-process, which enables out of process iframes (OOPIFs).
 class TaskManagerOOPIFBrowserTest : public TaskManagerBrowserTest,
                                     public testing::WithParamInterface<bool> {
  public:
   TaskManagerOOPIFBrowserTest() {}
 
  protected:
   void SetUpCommandLine(base::CommandLine* command_line) override {
     TaskManagerBrowserTest::SetUpCommandLine(command_line);
@@ skipping 509 matching lines @@
       MatchUtility(proxy_resolver_name), ColumnSpecifier::V8_MEMORY,
       minimal_heap_size));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerStatToExceed(
       MatchUtility(proxy_resolver_name), ColumnSpecifier::V8_MEMORY_USED,
       minimal_heap_size));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyUtility()));
   ASSERT_NO_FATAL_FAILURE(
       WaitForTaskManagerRows(1, MatchUtility(proxy_resolver_name)));
 }
 
+// Memory coordinator is not available on macos. crbug.com/617492
+#if defined(OS_MACOSX)
+#define MAYBE_MemoryState DISABLED_MemoryState
+#else
+#define MAYBE_MemoryState MemoryState
+#endif  // defined(OS_MACOSX)
+IN_PROC_BROWSER_TEST_F(TaskManagerMemoryCoordinatorBrowserTest,
+                       MAYBE_MemoryState) {
+  ShowTaskManager();
+  model()->ToggleColumnVisibility(ColumnSpecifier::MEMORY_STATE);
+  model()->ToggleColumnVisibility(ColumnSpecifier::V8_MEMORY_USED);
+
+  ui_test_utils::NavigateToURL(browser(), GetTestURL());
+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchTab("title1.html")));
+
+  // Wait until the tab consumes some memory so that memory state is refreshed.
+  size_t minimal_heap_size = 1024;
+  ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerStatToExceed(
+      MatchTab("title1.html"), ColumnSpecifier::V8_MEMORY_USED,
+      minimal_heap_size));
+
+  int row = FindResourceIndex(MatchTab("title1.html"));
+  ASSERT_NE(-1, row);
+  ASSERT_NE(base::MemoryState::UNKNOWN, model()->GetMemoryState(row));
+}
+
 IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, DevToolsNewDockedWindow) {
   ShowTaskManager();  // Task manager shown BEFORE dev tools window.
 
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, MatchAnyTab()));
   DevToolsWindow* devtools =
       DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true);
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(2, MatchAnyTab()));
   ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(2, MatchAnyTab()));
   DevToolsWindowTesting::CloseDevToolsWindowSync(devtools);
 }
@@ skipping 363 matching lines @@
 
     // Because the subframes for tab 2 are nested, their order is deterministic.
     EXPECT_EQ("Subframe: http://a.com/",
               base::UTF16ToUTF8(model()->GetRowTitle(tab2_start + 1)));
     EXPECT_EQ("Subframe: http://c.com/",
               base::UTF16ToUTF8(model()->GetRowTitle(tab2_start + 2)));
     EXPECT_EQ("Subframe: http://b.com/",
               base::UTF16ToUTF8(model()->GetRowTitle(tab2_start + 3)));
   }
 }