Gerrit tryjob: !tryjob can be anywhere

scripts/master/try_job_gerrit.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import re
 
 from twisted.internet import defer
 from twisted.python import log
 
@@ skipping 37 matching lines @@
 
 class _TryJobGerritPoller(GerritPoller):
   """Polls issues, creates changes and calls scheduler.submitJob.
 
   This class is a part of TryJobGerritScheduler implementation and not designed
   to be used otherwise.
   """
 
   change_category = 'tryjob'
 
-  MESSAGE_REGEX_TRYJOB = re.compile('Patch set \d+:\s+\!tryjob(.*)', re.I)
+  MESSAGE_REGEX_TRYJOB = re.compile('Patch set \d+:( Tryjob\+1)?\s+!tryjob(.*)',

[Vadim Sh., 2014/04/29 21:36:49]

Take care of Code-Review and Verified labels too then, since they also can be
set in same message.

Or just skip everything until you see !tryjob.

[nodir, 2014/04/29 21:49:46]

They shouldn't.
 
I thought of this. This allows anybody to submit a tryjob in any comment, like

Hey John, here is my change. PTAL. I am going to try on Master: !tryjob
["Master"]

But I'm not sure about this. What do you think?

+                                    re.I)
 
   def __init__(self, scheduler, gerrit_host, gerrit_projects=None,
                pollInterval=None):
     assert scheduler
     GerritPoller.__init__(self, gerrit_host, gerrit_projects, pollInterval)
     self.scheduler = scheduler
 
   def _is_interesting_message(self, message):
     return self.MESSAGE_REGEX_TRYJOB.match(message['message'])
 
@@ skipping 53 matching lines @@
   @defer.inlineCallbacks
   def submitJob(self, change, job):
     bsid = yield self.addBuildsetForChanges(
         reason='tryjob',
         changeids=[change.number],
         builderNames=job.builder_names,
         properties=change.properties)
     log.msg('Successfully submitted a Gerrit try job for %s: %s.' %
             (change.who, job))
     defer.returnValue(bsid)