Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 2593183002: [downloads] Remove DownloadManager::RemoveAllDownloads. (Closed)
Patch Set: Fix SavePageBrowsertest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/save_page_browsertest.cc
diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc
index fc82251dbabfe61307237d8e693f2b436f2a2cc8..b7665a55936b2e0dec291d4abea754b7cfbf3a3c 100644
--- a/chrome/browser/download/save_page_browsertest.cc
+++ b/chrome/browser/download/save_page_browsertest.cc
@@ -654,10 +654,9 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, RemoveFromList) {
std::vector<DownloadItem*> downloads;
manager->GetAllDownloads(&downloads);
ASSERT_EQ(1UL, downloads.size());
- DownloadRemovedObserver removed(browser()->profile(), downloads[0]->GetId());
-
- EXPECT_EQ(manager->RemoveAllDownloads(), 1);
+ DownloadRemovedObserver removed(browser()->profile(), downloads[0]->GetId());
+ downloads[0]->Remove();
removed.WaitForRemoved();
EXPECT_TRUE(base::PathExists(full_file_name));
@@ -800,7 +799,10 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, SaveDownloadableIFrame) {
ASSERT_TRUE(VerifySavePackageExpectations(browser(), download_url));
persisted.WaitForPersisted();
- GetDownloadManager()->RemoveAllDownloads();
+ std::vector<content::DownloadItem*> downloads;
+ GetDownloadManager()->GetAllDownloads(&downloads);
+ for (auto download : downloads)
+ download->Remove();
}
base::FilePath full_file_name, dir;
« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698