Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Unified Diff: net/socket/socket_posix.h

Issue 2593063003: Add Socket::ReadIfReady() (Closed)
Patch Set: self review. remove unused include Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/socket_posix.h
diff --git a/net/socket/socket_posix.h b/net/socket/socket_posix.h
index bf4b7e53d9b055793b3b6f6bb4bece7040268d2c..1ebec5ff5163cf0f50aad1ce6602d523ceffdb0d 100644
--- a/net/socket/socket_posix.h
+++ b/net/socket/socket_posix.h
@@ -59,6 +59,14 @@ class NET_EXPORT_PRIVATE SocketPosix : public base::MessageLoopForIO::Watcher {
// errno, though errno is set if read or write events happen with error.
// TODO(byungchul): Need more robust way to pass system errno.
int Read(IOBuffer* buf, int buf_len, const CompletionCallback& callback);
+
+ // Reads as much data as possible into |buf| without blocking. If read is to
Bence 2017/03/03 16:33:41 Optional: mention that no reference to |buf| is re
xunjieli 2017/03/03 19:41:06 Done.
+ // be retried later, |callback| will be invoked when data is ready for
+ // reading.
+ // See socket.h for more information.
+ int ReadIfReady(IOBuffer* buf,
+ int buf_len,
+ const CompletionCallback& callback);
int Write(IOBuffer* buf, int buf_len, const CompletionCallback& callback);
// Waits for next write event. This is called by TCPSocketPosix for TCP
@@ -95,6 +103,7 @@ class NET_EXPORT_PRIVATE SocketPosix : public base::MessageLoopForIO::Watcher {
void ConnectCompleted();
int DoRead(IOBuffer* buf, int buf_len);
+ void RetryRead(int rv);
void ReadCompleted();
int DoWrite(IOBuffer* buf, int buf_len);
@@ -109,11 +118,15 @@ class NET_EXPORT_PRIVATE SocketPosix : public base::MessageLoopForIO::Watcher {
CompletionCallback accept_callback_;
base::MessageLoopForIO::FileDescriptorWatcher read_socket_watcher_;
+
+ // Non-null when a Read() is in progress.
scoped_refptr<IOBuffer> read_buf_;
int read_buf_len_;
- // External callback; called when read is complete.
CompletionCallback read_callback_;
+ // Non-null when a ReadIfReady() is in progress.
+ CompletionCallback read_if_ready_callback_;
+
base::MessageLoopForIO::FileDescriptorWatcher write_socket_watcher_;
scoped_refptr<IOBuffer> write_buf_;
int write_buf_len_;

Powered by Google App Engine
This is Rietveld 408576698