Add Socket::ReadIfReady()

net/socket/socket.cc

Index: net/socket/socket.cc
diff --git a/net/socket/socket.cc b/net/socket/socket.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b46abec2999cf6317dc3b53a8689e89712075b1a
--- /dev/null
+++ b/net/socket/socket.cc
@@ -0,0 +1,20 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.

[Bence, 2017/03/03 16:33:40]

It seems to me that this patch was created already in 2017, please consider
updating year.  Although honestly I do not know what is the rule if you started
to work on the patch back in 2016 but only uploaded it in 2017.

BTW tools/boilerplate.py will create new files for you with current year.

[xunjieli, 2017/03/03 19:41:05]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/socket/socket.h"
+
+#include "net/base/net_errors.h"
+
+namespace net {
+
+const base::Feature Socket::kReadIfReadyExperiment{
+    "SocketReadIfReady", base::FEATURE_DISABLED_BY_DEFAULT};
+
+int Socket::ReadIfReady(IOBuffer* buf,

[Bence, 2017/03/03 16:33:40]

Every other method in this class is pure virtual.  Are you planning to remove
default implementation to make this one pure virtual as well?  (I know you
already have follow-up CLs in progress.)  In that case, consider adding a TODO
here, unless you plan to do it very soon (and you already have the CL lined up
and you want to save yourself the effort of resolving a merge conflict).

[xunjieli, 2017/03/03 19:41:05]

No, we are keeping the default implementation. I don't think we should inline it
right? 

[Bence, 2017/03/06 23:43:14]

No for inlining.  I believe Chromium enforces that no virtual methods can be
inlined (by a clang plugin).

+                        int buf_len,
+                        const CompletionCallback& callback) {
+  return ERR_READ_IF_READY_NOT_IMPLEMENTED;
+}
+
+}  // namespace net