net/base/net_error_list.h - Issue 2593063003: Add Socket::ReadIfReady()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_error_list.h

Issue 2593063003: Add Socket::ReadIfReady() (Closed)

Patch Set: self review. remove unused include Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/net_error_list.h

diff --git a/net/base/net_error_list.h b/net/base/net_error_list.h

index 617a56d41f754f36aef1b77d488015829b969b57..91f609516bb6fb272743ac3c1c4c114460677ae3 100644

--- a/net/base/net_error_list.h

+++ b/net/base/net_error_list.h

@@ -386,6 +386,9 @@ NET_ERROR(SSL_OBSOLETE_CIPHER, -172)

// upgraded, the URLRequest is cancelled with this error code.

NET_ERROR(WS_UPGRADE, -173)

+// Socket ReadIfReady support is not implemented.

Bence 2017/03/03 16:33:40 Do you plan to support ReadIfReady() on every Sock

Bence 2017/03/03 16:33:40 Maybe append ", Read() should be used instead."

xunjieli 2017/03/03 19:41:05 Done.

xunjieli 2017/03/03 19:41:05 Nope. We aren't going to support every Socket impl

+NET_ERROR(READ_IF_READY_NOT_IMPLEMENTED, -174)

// Certificate error codes

// The values of certificate error codes must be consecutive.

« no previous file with comments | « net/BUILD.gn ('k') | net/socket/socket.h » ('j') | net/socket/socket.h » ('J')