chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc - Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)

Patch Set: Disabled test on MacOS >=10.11, added ref to bug. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.h ('k') | content/browser/devtools/protocol/devtools_protocol_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

diff --git a/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc b/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

index fe9264c2a3ce02e1b5356ddf8dc2b4a259381a3c..eec0979395c89a1f0f80c3e406f44673ea92191e 100644

--- a/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

+++ b/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc

@@ -42,7 +42,7 @@ void ScreenshotDelegate::TakeSnapshot(

gfx::NativeWindow window,

const gfx::Rect& source_rect,

const ui::GrabWindowSnapshotAsyncPNGCallback& callback) {

- ui::GrabWindowSnapshotAsync(

+ ui::GrabWindowSnapshotAsyncPNG(

window, source_rect, blocking_task_runner_,

base::Bind(&ScreenshotDelegate::StoreScreenshot,

weak_ptr_factory_.GetWeakPtr(), callback));

@@ -69,7 +69,7 @@ std::unique_ptr<UploadJob> ScreenshotDelegate::CreateUploadJob(

void ScreenshotDelegate::StoreScreenshot(

const ui::GrabWindowSnapshotAsyncPNGCallback& callback,

- scoped_refptr<base::RefCountedBytes> png_data) {

+ scoped_refptr<base::RefCountedMemory> png_data) {

callback.Run(png_data);

}