chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h - Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)

Patch Set: Disabled test on MacOS >=10.11, added ref to bug. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/feedback/screenshot_task.cc ('k') | chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

diff --git a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

index 64741571f6500568bd7e3a5806fb4f9371bd9d1c..eafd43ecc4e712dd45d957fac4744cb386794d6c 100644

--- a/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

+++ b/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.h

@@ -24,7 +24,7 @@ class ScreenshotTester {

ScreenshotTester();

virtual ~ScreenshotTester();

- typedef scoped_refptr<base::RefCountedBytes> PNGFile;

+ typedef scoped_refptr<base::RefCountedMemory> PNGFile;

// Contains the results of comparison

struct Result {

@@ -106,7 +106,7 @@ class ScreenshotTester {

void LogComparisonResults(const ScreenshotTester::Result& result);

// Saves |png_data| as a current screenshot.

- void ReturnScreenshot(const PNGFile& screenshot, PNGFile png_data);

+ void ReturnScreenshot(PNGFile* screenshot, PNGFile png_data);

// Loads golden screenshot from the disk, assuming it lies at |image_path|.

// Fails if there is no such a file.

@@ -138,7 +138,7 @@ class ScreenshotTester {

base::FilePath artifacts_dir_;

// |run_loop_quitter_| is used to stop waiting when

- // ui::GrabWindowSnapshotAsync completes.

+ // ui::GrabWindowSnapshotAsyncPNG completes.

base::Closure run_loop_quitter_;

// Is true when we're in test mode: