Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)
Patch Set: fix return value description + rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.h
diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h
index 32f80267eb3d92094559c551ead1a7011d8bc636..0bb50c4a1937beac455841fcc14b44f08a66e40f 100644
--- a/content/browser/devtools/protocol/page_handler.h
+++ b/content/browser/devtools/protocol/page_handler.h
@@ -60,6 +60,8 @@ class PageHandler : public Page::Backend,
Response NavigateToHistoryEntry(int entry_id) override;
void CaptureScreenshot(
+ Maybe<std::string> format,
+ Maybe<int> quality,
std::unique_ptr<CaptureScreenshotCallback> callback) override;
Response StartScreencast(Maybe<std::string> format,
Maybe<int> quality,
@@ -96,10 +98,12 @@ class PageHandler : public Page::Backend,
const base::Time& timestamp,
const std::string& data);
- void ScreenshotCaptured(
- std::unique_ptr<CaptureScreenshotCallback> callback,
- const unsigned char* png_data,
- size_t png_size);
+ void ScreenshotCaptured(std::unique_ptr<CaptureScreenshotCallback> callback,
+ const std::string& format,
+ int quality,
+ const SkBitmap& bitmap);
+ void ScreenshotEncoded(std::unique_ptr<CaptureScreenshotCallback> callback,
+ const std::string& data);
void OnColorPicked(int r, int g, int b, int a);

Powered by Google App Engine
This is Rietveld 408576698