Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: content/browser/devtools/protocol/page_handler.h

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)
Patch Set: Wait for load in CaptureScreenshotTest to fix android bot. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/page_handler.h
diff --git a/content/browser/devtools/protocol/page_handler.h b/content/browser/devtools/protocol/page_handler.h
index fdb1ac59ae589c4e99aa1d49dbddad9b305024f9..5ebaa0ca872a9711b6addf920125eb3ad28db1a4 100644
--- a/content/browser/devtools/protocol/page_handler.h
+++ b/content/browser/devtools/protocol/page_handler.h
@@ -20,6 +20,10 @@
class SkBitmap;
+namespace gfx {
+class Image;
+} // namespace gfx
+
namespace content {
class DevToolsSession;
@@ -65,6 +69,8 @@ class PageHandler : public DevToolsDomainHandler,
Response NavigateToHistoryEntry(int entry_id) override;
void CaptureScreenshot(
+ Maybe<std::string> format,
+ Maybe<int> quality,
std::unique_ptr<CaptureScreenshotCallback> callback) override;
Response StartScreencast(Maybe<std::string> format,
Maybe<int> quality,
@@ -91,6 +97,8 @@ class PageHandler : public DevToolsDomainHandler,
void NavigationRequested(const PageNavigationThrottle* throttle);
private:
+ enum EncodingFormat { PNG, JPEG };
+
WebContentsImpl* GetWebContents();
void NotifyScreencastVisibility(bool visible);
void InnerSwapCompositorFrame();
@@ -101,10 +109,10 @@ class PageHandler : public DevToolsDomainHandler,
const base::Time& timestamp,
const std::string& data);
- void ScreenshotCaptured(
- std::unique_ptr<CaptureScreenshotCallback> callback,
- const unsigned char* png_data,
- size_t png_size);
+ void ScreenshotCaptured(std::unique_ptr<CaptureScreenshotCallback> callback,
+ const std::string& format,
+ int quality,
+ const gfx::Image& image);
void OnColorPicked(int r, int g, int b, int a);

Powered by Google App Engine
This is Rietveld 408576698