Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: ui/snapshot/snapshot_ios.mm

Issue 2592983002: [devtools] Support different encodings for Page.CaptureScreenshot. (Closed)
Patch Set: Encode in ui snapshot methods instead. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/snapshot/snapshot_ios.mm
diff --git a/ui/snapshot/snapshot_ios.mm b/ui/snapshot/snapshot_ios.mm
index d75f204fe8dc18897cbd96c0db4820341db2d645..1b06557b12789230a0b257c490082a84137336a3 100644
--- a/ui/snapshot/snapshot_ios.mm
+++ b/ui/snapshot/snapshot_ios.mm
@@ -12,14 +12,18 @@ namespace ui {
bool GrabViewSnapshot(gfx::NativeView view,
std::vector<unsigned char>* png_representation,
- const gfx::Rect& snapshot_bounds) {
+ const gfx::Rect& snapshot_bounds,
+ SnapshotEncoding encoding,
+ SnapshotQuality quality) {
// TODO(bajones): Implement iOS snapshot functionality
return false;
}
bool GrabWindowSnapshot(gfx::NativeWindow window,
std::vector<unsigned char>* png_representation,
- const gfx::Rect& snapshot_bounds) {
+ const gfx::Rect& snapshot_bounds,
+ SnapshotEncoding encoding,
+ SnapshotQuality quality) {
// TODO(bajones): Implement iOS snapshot functionality
return false;
}
@@ -37,7 +41,9 @@ void GrabViewSnapshotAsync(
gfx::NativeView view,
const gfx::Rect& source_rect,
scoped_refptr<base::TaskRunner> background_task_runner,
- const GrabWindowSnapshotAsyncPNGCallback& callback) {
+ const GrabWindowSnapshotAsyncEncodedCallback& callback,
+ SnapshotEncoding encoding,
+ SnapshotQuality quality) {
callback.Run(scoped_refptr<base::RefCountedBytes>());
}
@@ -45,7 +51,9 @@ void GrabWindowSnapshotAsync(
gfx::NativeWindow window,
const gfx::Rect& source_rect,
scoped_refptr<base::TaskRunner> background_task_runner,
- const GrabWindowSnapshotAsyncPNGCallback& callback) {
+ const GrabWindowSnapshotAsyncEncodedCallback& callback,
+ SnapshotEncoding encoding,
+ SnapshotQuality quality) {
callback.Run(scoped_refptr<base::RefCountedBytes>());
}

Powered by Google App Engine
This is Rietveld 408576698