Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2592803004: Initialize devil_chromium when in chromium checkout.

Created:
4 years ago by djordje.golubovic
Modified:
4 years ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, gordana.cmiljanovic_imgtec.com, petar.jovanovic
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Initialize devil_chromium when in chromium checkout. Runs devil_chromium.Initialize(...) if devil_chromium module is injected, if not - fall back to devil_env.config.Initialize(...) Lets telemetry work with locally built architectures, but only through chromium checkout. BUG=chromium:669849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M telemetry/telemetry/internal/util/binary_manager.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
djordje.golubovic
Please take a look
4 years ago (2016-12-21 18:00:16 UTC) #4
jbudorick
As mentioned in the other review, I'd prefer the other solution.
4 years ago (2016-12-21 18:05:10 UTC) #5
djordje.golubovic
On 2016/12/21 18:05:10, jbudorick wrote: > As mentioned in the other review, I'd prefer the ...
4 years ago (2016-12-21 18:38:59 UTC) #6
jbudorick
4 years ago (2016-12-21 18:41:15 UTC) #7
On 2016/12/21 18:38:59, djordje.golubovic wrote:
> On 2016/12/21 18:05:10, jbudorick wrote:
> > As mentioned in the other review, I'd prefer the other solution.
> 
> My mistake, I've misread.

No, I don't think you did; I just think we're still kind of working through the
appropriate solution here.

> 
> Posted another patch set to the other review, if you could take a look,
please.
> https://codereview.chromium.org/2573913002

Powered by Google App Engine
This is Rietveld 408576698