Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java

Issue 2592733002: [Payments] Update billing address dropdown style to match the design (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
index fcbed1fb0d60afa8447c07ea37e6e55234370963..eb099cb3da0a1b93df61f03d98a9776eb60cad6a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
@@ -70,8 +70,8 @@ class EditorDropdownField implements EditorFieldView {
} else {
adapter = new ArrayAdapter<DropdownKeyValue>(
context, R.layout.multiline_spinner_item, dropdownKeyValues);
+ adapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
Ian Wen 2016/12/21 23:04:25 I think there is a better way here: 1. replace R.l
gogerald1 2017/01/04 16:00:51 Not sure I understand this comment correctly. He
}
- adapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
mDropdown = (Spinner) mLayout.findViewById(R.id.spinner);
mDropdown.setTag(this);
@@ -92,6 +92,8 @@ class EditorDropdownField implements EditorFieldView {
@Override
public void onNothingSelected(AdapterView<?> parent) {}
});
+ // Remove padding so that dropdown has the same width as the spinner.
+ mDropdown.setPadding(0, 0, 0, 0);
Ian Wen 2016/12/21 23:04:25 Could this be done in xml? If so, let's do it ther
gogerald1 2017/01/04 16:00:51 Done.
}
/** @return The View containing everything. */

Powered by Google App Engine
This is Rietveld 408576698