chrome/android/java/res/layout/payment_request_dropdown_item.xml - Issue 2592733002: [Payments] Update billing address dropdown style to match the design

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/payment_request_dropdown_item.xml

Issue 2592733002: [Payments] Update billing address dropdown style to match the design (Closed)

Patch Set: address comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6

	7 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
	Ian Wen 2016/12/21 23:04:24 1. The wrapping here might not be necessary. TextV 1. The wrapping here might not be necessary. TextView itself could carry a padding. 2. Even if there is a need for such wrapping, FrameLayout should be favored as it is lighter than LinearLayout. gogerald1 2017/01/04 16:00:51 The wrap is to display texts in multiple lines. Sp Show quoted text On 2016/12/21 23:04:24, Ian Wen wrote: > 1. The wrapping here might not be necessary. TextView itself could carry a > padding. > 2. Even if there is a need for such wrapping, FrameLayout should be favored as > it is lighter than LinearLayout. The wrap is to display texts in multiple lines. Spinner dropdown is displayed in a DropDownListView which displays the item in a single line if it is an instance of TextView. FrameLayout do seems better here,
	8 android:layout_width="match_parent"

	9 android:layout_height="wrap_content">

	10

	11 <TextView

	12 android:id="@+id/dropdown_item"

	13 android:layout_width="match_parent"

	14 android:layout_height="wrap_content"

	15 android:paddingStart="24dp"

	16 android:paddingEnd="24dp"

	17 android:minHeight="48dp"

	18 style="?android:attr/spinnerDropDownItemStyle" />

	19

	20 </LinearLayout>

OLD	NEW